Jorijn de Graaf bonj
2 Followers · 0 Following
  • Joined on 2023-02-10
Repositories
2
 Projects Public Activity Starred Repositories
1
Jorijn de Graaf pushed to retopology-select at bonj/blender 2023-03-22 00:54:12 +01:00
dd0fbac2b4 Merge branch 'main' into retopology-select
64ef514ec9 Cleanup: format
dd7e1a3574 Fix: Hide corner vert and edge attributes in UI
45379d9b59 Fix (unreported): Snap not enabled if Ctrl is pressed before operation
dab0ab673e BLI: Add a default constructor to OffsetIndices
Compare 64 commits »
Jorijn de Graaf pushed to retopology-select at bonj/blender 2023-03-19 17:30:04 +01:00
4cc2ac92aa Merge branch 'main' into retopology-select
63a44e29ac Mesh: Parallelize extraction of UV maps
f149d7625d Cleanup: Use more specific variable names for color attributes
35bb942ae3 Cleanup: Use better check for UV map attribute
37889015f3 Cleanup: Use C++ attribute API
Compare 148 commits »
Jorijn de Graaf commented on pull request blender/blender#105871 2023-03-19 01:30:15 +01:00
Fix #105152: Removing color attribute doesn't update active

Oh should I have targeted the 3.5 branch? Anyway thanks!

Jorijn de Graaf commented on pull request blender/blender#105871 2023-03-19 00:14:08 +01:00
Fix #105152: Removing color attribute doesn't update active

@HooglyBoogly I've changed the title and description to hopefully be suitable. Sorry it took so long, I got distracted.

Jorijn de Graaf commented on pull request blender/blender#105871 2023-03-18 22:53:48 +01:00
Fix #105152: Removing color attribute doesn't update active

@HooglyBoogly Okay it uses an early return in both places now, and I've added the cleanup commit.

Jorijn de Graaf pushed to fix/remove-color-attribute at bonj/blender 2023-03-18 22:49:43 +01:00
a6712399c0 Merge branch 'main' into fix/remove-color-attribute
335688dd42 EEVEE-Next: Deferred Pipeline
b93a66d603 IO: refactor, replace std::vector with Vector in OBJ and PLY code
1b2f58adff VSE: Update text of text strip after each typed character
bb1c503bee Fix 105824: Retiming remove gizmo size is fixed
Compare 5 commits »
Jorijn de Graaf pushed to fix/remove-color-attribute at bonj/blender 2023-03-18 22:48:12 +01:00
09d0349c43 Invert attribute remove check and use early return
Jorijn de Graaf pushed to fix/remove-color-attribute at bonj/blender 2023-03-18 22:44:03 +01:00
f3be034b63 Remove next_color_attribute utilities
Jorijn de Graaf deleted branch cleanup/next-color-attribute from bonj/blender 2023-03-18 22:43:39 +01:00
Jorijn de Graaf closed pull request blender/blender#105886 2023-03-18 22:43:34 +01:00
WIP: Cleanup: Remove unused color attribute utilities
Jorijn de Graaf commented on pull request blender/blender#105886 2023-03-18 22:43:33 +01:00
WIP: Cleanup: Remove unused color attribute utilities

I was asked to include these changes in the fix PR, so I'll close this PR.

Jorijn de Graaf created pull request blender/blender#105886 2023-03-18 21:31:38 +01:00
WIP: Cleanup: Remove unused color attribute utilities
Jorijn de Graaf commented on pull request blender/blender#105871 2023-03-18 19:21:19 +01:00
Fix #105152: Removing color attribute doesn't update active

@HooglyBoogly Alright done. This works as it should, but only for meshes; it doesn't affect behavior for Point Cloud or the new Curves type. I'm removing the now unused utility functions in a…

Jorijn de Graaf pushed to cleanup/next-color-attribute at bonj/blender 2023-03-18 19:16:51 +01:00
47a46e9cbb Remove next_color_attribute utilities
b93a66d603 IO: refactor, replace std::vector with Vector in OBJ and PLY code
1b2f58adff VSE: Update text of text strip after each typed character
bb1c503bee Fix 105824: Retiming remove gizmo size is fixed
Compare 4 commits »
Jorijn de Graaf created branch cleanup/next-color-attribute in bonj/blender 2023-03-18 19:16:51 +01:00
Jorijn de Graaf pushed to fix/remove-color-attribute at bonj/blender 2023-03-18 19:14:17 +01:00
395ae6a504 Use utility functions to restore color attributes
Jorijn de Graaf commented on pull request blender/blender#105871 2023-03-18 15:08:43 +01:00
Fix #105152: Removing color attribute doesn't update active

Thanks for looking into this. Based on the code, it looks like it's missing moving to the previous active/default index when removing the last color attribute.

Correct, I didn't get around to…

Jorijn de Graaf created pull request blender/blender#105871 2023-03-18 04:15:41 +01:00
WIP: Fix #105152 Removing a color attribute may leave a mesh without an active color attribute
Jorijn de Graaf created branch fix/remove-color-attribute in bonj/blender 2023-03-18 04:13:01 +01:00
Jorijn de Graaf pushed to fix/remove-color-attribute at bonj/blender 2023-03-18 04:13:01 +01:00
9ecb895c92 Don't use next_color_attribute
10ab93a095 Restore active/default color attribute using index
cf8640e7b5 Fix: Broken mesh to curve conversion
740c9204cc Cleanup: Simplify mesh to legacy curve logic
Compare 4 commits »