Brecht Van Lommel brecht
  • Blender & Cycles developer

  • Joined on 2003-01-03
Brecht Van Lommel deleted branch eagle from Zopolis4/blender 2024-06-12 16:37:06 +02:00
Brecht Van Lommel merged pull request blender/blender#122865 2024-06-12 16:37:04 +02:00
Use set_and_warn_dependency to disable WITH_MOD_OCEANSIM if WITH_FFTW3 is disabled.
Brecht Van Lommel pushed to blender-v4.2-release at blender/blender 2024-06-12 16:37:03 +02:00
0a74065a19 Build: Disable WITH_MOD_OCEANSIM when WITH_FFTW3 is disabled
Brecht Van Lommel approved blender/blender#121718 2024-06-12 15:42:03 +02:00
UI: Render SVG Files for UI Icons

The implementation looks fine to me now.

Brecht Van Lommel commented on pull request blender/blender#121718 2024-06-12 01:26:06 +02:00
UI: Render SVG Files for UI Icons

Actually this doesn't need to be an unordered map either?

It could just be an array of const char*, since the ICON_ defines are just indices starting from 0.

Brecht Van Lommel commented on pull request blender/blender#121718 2024-06-12 01:21:42 +02:00
UI: Render SVG Files for UI Icons

This could use const char* instead of std::string, no need to dynamically allocate this on startup.

Brecht Van Lommel commented on issue blender/blender#122617 2024-06-12 01:14:21 +02:00
Blender rendered EXR result in media texture frame skipping in Unreal Engine 5 - possible EXR IO issue?

It seems both use scanlines and not tiled, so that's not it.

The most obvious difference is that Blender is using DWA compression instead of ZIP, which makes the files much smaller but could…

Brecht Van Lommel suggested changes for blender/blender#121718 2024-06-12 00:55:22 +02:00
UI: Render SVG Files for UI Icons

When measuring startup time, you generally need to check both cold and warm starts. Did you try both?

Brecht Van Lommel commented on pull request blender/blender#121718 2024-06-12 00:55:21 +02:00
UI: Render SVG Files for UI Icons

Doing all this string manipulation for every icon draw seems unnecessary.

Brecht Van Lommel commented on pull request blender/blender#121718 2024-06-12 00:55:20 +02:00
UI: Render SVG Files for UI Icons

blender::Vector or blender::Array is preferred in new code.

Brecht Van Lommel commented on pull request blender/blender#121718 2024-06-12 00:55:19 +02:00
UI: Render SVG Files for UI Icons

If reading fails, I think it should still have some kind of placeholder in the cache? Otherwise if an icon is missing, it will keep re-trying to read the file every time.

Brecht Van Lommel commented on issue blender/blender#120702 2024-06-11 21:19:06 +02:00
Cycles HIP-RT Memory leak

Thanks, I set the milestone to 4.3.

Brecht Van Lommel pushed to hiprt-cmake at brecht/blender 2024-06-11 21:13:37 +02:00
bb2afcfac5 WIP: Use latest RC and CMake build system
f6c5833746 Merge branch 'main' into HEAD
deedb52a7e Merge branch 'blender-v4.2-release'
354b1a5db9 Fix #122933: Enable Compositor OpenImageDenoise on Linux ARM64
1dfdf098d2 Fix #122933: Enable Cycles OpenImageDenoise on Linux ARM64
Compare 10 commits »
Brecht Van Lommel created branch hiprt-cmake in brecht/blender 2024-06-11 21:13:36 +02:00
Brecht Van Lommel commented on pull request blender/blender#121050 2024-06-11 21:08:51 +02:00
Cycles: Linux Support for HIP-RT

For reference these are the changes I did to change to CMake, but I didn't push to the branch as it's not working for reasons mentioned.

Diff
diff --git…
Brecht Van Lommel commented on pull request blender/blender#121050 2024-06-11 21:05:26 +02:00
Cycles: Linux Support for HIP-RT

easy-encription is no longer needed. Thanks for the feedback. We'll update HIP-RT and let you know.

Thanks. I got build error due to missing easy-encryption headers, and missing binary in the…

Brecht Van Lommel commented on pull request blender/blender#121050 2024-06-11 20:46:48 +02:00
Cycles: Linux Support for HIP-RT

@salipour It seems this added CMake support, but most of the reasons for why I needed these patches still remain. For references these are the patches: https://projects.blender.org/blender/blender

Brecht Van Lommel commented on issue blender/blender#122779 2024-06-11 20:11:48 +02:00
Illegal address error with OptiX OSL with specific materials

CC @pmoursnv in case it's a driver issue.

I'll test the 555 driver.