Actually this doesn't need to be an unordered map either?
It could just be an array of const char*
, since the ICON_
defines are just indices starting from 0.
This could use const char*
instead of std::string
, no need to dynamically allocate this on startup.
It seems both use scanlines and not tiled, so that's not it.
The most obvious difference is that Blender is using DWA compression instead of ZIP, which makes the files much smaller but could…
When measuring startup time, you generally need to check both cold and warm starts. Did you try both?
Doing all this string manipulation for every icon draw seems unnecessary.
If reading fails, I think it should still have some kind of placeholder in the cache? Otherwise if an icon is missing, it will keep re-trying to read the file every time.
For reference these are the changes I did to change to CMake, but I didn't push to the branch as it's not working for reasons mentioned.
Diff
diff --git…
easy-encription is no longer needed. Thanks for the feedback. We'll update HIP-RT and let you know.
Thanks. I got build error due to missing easy-encryption headers, and missing binary in the…
@salipour It seems this added CMake support, but most of the reasons for why I needed these patches still remain. For references these are the patches: https://projects.blender.org/blender/blender…
CC @pmoursnv in case it's a driver issue.
I'll test the 555 driver.