dr.sybren/rignodes
11
14
Fork 2
Code Issues Pull Requests 5 Projects Releases Wiki Activity

Motion transfer setup #1

Manually merged
Sybren A. Stüvel merged 18 commits from cgtinker/powership:motion_transfer into main 2023-06-05 12:06:15 +02:00
Conversation 6 Commits 18 Files Changed 4 +4 -4
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 65dece1627 - Show all commits

8
nodes.py
View File

@ -601,9 +601,9 @@ class ToVector(AbstractPowerShipNode):
self.outputs.new("NodeSocketVector", "Vector")
cgtinker marked this conversation as resolved Outdated
Sybren A. Stüvel commented 2023-06-01 11:18:40 +02:00
Outdated
Review
Copy Link

This can be simplified by using shortcutting (a or b evaluates to b when a is falsey).

        x = self._get_optional_input_value("X", float) or 0.0
        y = self._get_optional_input_value("Y", float) or 0.0
        z = self._get_optional_input_value("Z", float) or 0.0

        v = Vector((x, y, z))
This can be simplified by using shortcutting (`a or b` evaluates to `b` when `a` is falsey). ```py x = self._get_optional_input_value("X", float) or 0.0 y = self._get_optional_input_value("Y", float) or 0.0 z = self._get_optional_input_value("Z", float) or 0.0 v = Vector((x, y, z)) ```
def execute(self, depsgraph: bpy.types.Depsgraph) -> None:
x = self.inputs["X"].default_value or 0.0
y = self.inputs["Y"].default_value or 0.0
z = self.inputs["Z"].default_value or 0.0
x = self.inputs["X"].default_value
y = self.inputs["Y"].default_value
z = self.inputs["Z"].default_value
self.outputs["Vector"].default_value = Vector((x, y, z))
@ -690,7 +690,7 @@ class RotateTowards(AbstractPowerShipNode):
bl_icon = "EMPTY_ARROWS"
track: bpy.props.EnumProperty( # type: ignore
name="Track", items=_enum_track_axis_items, default="X"
name="Track", items=_enum_track_axis_items, default="Z"
)
up: bpy.props.EnumProperty( # type: ignore