Clément Foucault fclem
  • I'm pixel pusher.

  • Joined on 2014-07-09
Clément Foucault approved blender/blender#104880 2023-02-27 10:21:05 +01:00
Vulkan: Push constants

Pretty solid. 👍

Clément Foucault commented on pull request blender/blender#104880 2023-02-27 10:21:04 +01:00
Vulkan: Push constants

I think Layout should be LayoutT to avoid thinking it is the layout itself (as in the content of a UBO/SSBO).

Clément Foucault commented on pull request blender/blender#104880 2023-02-27 10:21:04 +01:00
Vulkan: Push constants

components_mul > vector_mul

Clément Foucault commented on pull request blender/blender#104880 2023-02-27 10:21:04 +01:00
Vulkan: Push constants

You could test if the array is tightly packed and do only one memcpy.

Clément Foucault commented on pull request blender/blender#104741 2023-02-27 09:58:57 +01:00
UI: Added Edge Width option in preferences for 3DView and UV/Image Editor

I don't understand this value. It looks like it was copied from gb->size_vertex. For point size it make sense because there was a square dot to circle dot surface conversion (from the 2.8 days).

Clément Foucault commented on pull request blender/blender#104741 2023-02-27 09:58:57 +01:00
UI: Added Edge Width option in preferences for 3DView and UV/Image Editor

This should be move right after TH_VERTEX_SIZE.

Clément Foucault commented on pull request blender/blender#104599 2023-02-26 22:04:32 +01:00
#70267 Retopology Overlay

I think it is nice to link this comment blender/blender#104921 (comment) to this PR. It has some nice related explanation and it prevents to see it…

Clément Foucault commented on pull request blender/blender#104599 2023-02-26 21:55:57 +01:00
#70267 Retopology Overlay

Yes, but here it is the reference to a specific formula. I also think this reference should be inside the function. Comment on top of function is only for documentation of the function usage.

Clément Foucault suggested changes for blender/blender#104599 2023-02-26 19:06:29 +01:00
#70267 Retopology Overlay

This feels nice! Only some final touch ups required in my opinion.

Clément Foucault commented on pull request blender/blender#104599 2023-02-26 19:06:29 +01:00
#70267 Retopology Overlay

Maybe also add a note that offset is in viewspace. So positive values are closer to camera.

Clément Foucault commented on pull request blender/blender#104599 2023-02-26 19:06:28 +01:00
#70267 Retopology Overlay

Remove the negative sign here and everywhere get_homogenous_z_offset is called.

Clément Foucault commented on pull request blender/blender#104599 2023-02-26 19:06:28 +01:00
#70267 Retopology Overlay

Replace description by Offset used to draw the edit mesh in front of other geometry.

Clément Foucault commented on pull request blender/blender#104599 2023-02-26 19:06:28 +01:00
#70267 Retopology Overlay

Now that we fixed the bias equation, the property types should be PROP_DISTANCE.

Clément Foucault commented on pull request blender/blender#104599 2023-02-26 19:06:28 +01:00
#70267 Retopology Overlay

Style: Prefer:

Clément Foucault commented on pull request blender/blender#104599 2023-02-26 19:06:28 +01:00
#70267 Retopology Overlay

Same thing here.

Clément Foucault commented on pull request blender/blender#104599 2023-02-26 19:06:28 +01:00
#70267 Retopology Overlay

My bad. The equation is actually comming from page 24.

Clément Foucault commented on pull request blender/blender#104599 2023-02-26 19:06:27 +01:00
#70267 Retopology Overlay

Max should be FLT_MAX. Arbitrary limits like these are not good.