Clément Foucault fclem
  • I'm pixel pusher.

  • Joined on 2014-07-09
Clément Foucault commented on pull request blender/blender#104536 2023-02-14 12:49:34 +01:00
Eevee: GPU Material node graph optimization.

In the header.

Clément Foucault commented on pull request blender/blender#104536 2023-02-14 12:39:34 +01:00
Eevee: GPU Material node graph optimization.

Thanks, I understand better now. But then the documentation about this is rather lacking. It is not stated that the parent material is just a template and that the actual final shader can actually…

Clément Foucault commented on pull request blender/blender#104599 2023-02-14 02:23:42 +01:00
#70267 Retopology Overlay

You edit a file that is used in other part of the engine. Maybe it is better to duplicate the shader as overlay_edit_mesh_depth_vert.glsl.

Clément Foucault suggested changes for blender/blender#104599 2023-02-14 02:23:42 +01:00
#70267 Retopology Overlay
Clément Foucault commented on pull request blender/blender#104599 2023-02-14 02:23:42 +01:00
#70267 Retopology Overlay

Did you create this file only to modify the depth_only shader?

Clément Foucault commented on pull request blender/blender#104599 2023-02-14 02:23:42 +01:00
#70267 Retopology Overlay

I am pretty sure the bias is incorrect.

Clément Foucault commented on pull request blender/blender#104599 2023-02-14 02:23:42 +01:00
#70267 Retopology Overlay

Move the max out of the shader. That stands for all shaders.

Clément Foucault commented on pull request blender/blender#104518 2023-02-14 02:04:48 +01:00
Vulkan: Initial Compute Shaders support.
Clément Foucault approved blender/blender#104518 2023-02-14 02:04:48 +01:00
Vulkan: Initial Compute Shaders support.

This looks pretty solid!

Clément Foucault commented on pull request blender/blender#104518 2023-02-14 02:04:47 +01:00
Vulkan: Initial Compute Shaders support.

Cant we make that part of a header to avoid the duplication?

Clément Foucault commented on pull request blender/blender#104580 2023-02-14 01:07:20 +01:00
EEVEE Next: Tag shadowmap usage for transparent object volumes

Be conservative in Z too. Bias far_box_t by step_size to have one more iteration before and after.

Clément Foucault suggested changes for blender/blender#104580 2023-02-14 01:07:20 +01:00
EEVEE Next: Tag shadowmap usage for transparent object volumes

I think the debug code is confusing and not isolated. Might be better to remove it. We don't need that in production (I mean the cost of having a separate framebuffer + clear etc...), you can just use an empty framebuffer for that.

Clément Foucault commented on pull request blender/blender#104580 2023-02-14 01:07:20 +01:00
EEVEE Next: Tag shadowmap usage for transparent object volumes

Use exp2 instead of pow(2, x). Try to apply this everywhere.

Clément Foucault commented on pull request blender/blender#104580 2023-02-14 01:07:20 +01:00
EEVEE Next: Tag shadowmap usage for transparent object volumes

I think we need a fullpixel here.

Clément Foucault commented on pull request blender/blender#104580 2023-02-14 01:07:20 +01:00
EEVEE Next: Tag shadowmap usage for transparent object volumes

Im' not sure why you are changing that for the debug visuals.

Clément Foucault commented on pull request blender/blender#104580 2023-02-14 01:07:20 +01:00
EEVEE Next: Tag shadowmap usage for transparent object volumes

This only works because max_v2 is a define. Use vs_inflate_vector.xy to avoid the confusion.

Clément Foucault commented on pull request blender/blender#104687 2023-02-13 23:22:10 +01:00
Metal: Resolve race condition when releasing large numbers of buffers simultaneously.

I didn't catch that first but has_next_pool_ is basically the list length. Might be worth renaming the variable.

Clément Foucault commented on pull request blender/blender#104687 2023-02-13 23:22:10 +01:00
Metal: Resolve race condition when releasing large numbers of buffers simultaneously.

I have to admit I'm a bit doubtful about what's the intent here. Is the lock thing inside the loop supposed to just slow down the waiting thread and avoid high CPU usage? This does feel hacky anyway.