Clément Foucault fclem
29 Followers · 0 Following

  • I'm pixel pusher.

  • Joined on 2014-07-09
Repositories
3
 Projects Public Activity Starred Repositories
Clément Foucault commented on pull request blender/blender#104536 2023-02-13 22:02:33 +01:00
Eevee: GPU Material node graph optimization.

As a side note, I think the patch is in mergeable state, that's why I approved it. But would like to see the small fixes be done first.

Clément Foucault commented on pull request blender/blender#104536 2023-02-13 22:01:38 +01:00
Eevee: GPU Material node graph optimization.

How does that work? Material can have different resources based on their flag (see EEVEE_material_bind_resources(à). Unless this is only for the vertex inputs and fragment outputs, these should be the same.

Clément Foucault commented on pull request blender/blender#104536 2023-02-13 22:01:38 +01:00
Eevee: GPU Material node graph optimization.

Maybe note what is the expected status of both parameters. I guess material can be in any state, whereas default_material should be compiled?

Clément Foucault commented on pull request blender/blender#104536 2023-02-13 22:01:38 +01:00
Eevee: GPU Material node graph optimization.

Document this function.

Clément Foucault approved blender/blender#104536 2023-02-13 22:01:38 +01:00
Eevee: GPU Material node graph optimization.

I think the patch is clear and usage is all good.

Clément Foucault approved blender/blender#104716 2023-02-13 20:10:37 +01:00
Cleanup: Move draw_attributes.hh to C++
Clément Foucault closed issue blender/blender#103397 2023-02-13 18:16:54 +01:00
MacOS Metal GPU backend: Vector UI control not visible
Clément Foucault pushed to main at blender/blender 2023-02-13 18:16:54 +01:00
c2a5c592fe Fix #103397: Vector UI control shader UBO alignment fix.
Clément Foucault merged pull request blender/blender#104699 2023-02-13 18:16:52 +01:00
Fix T103397: Vector UI control shader UBO alignment fix.
Clément Foucault pushed to Fix_T103397_v3 at Jason-Fielder/blender 2023-02-13 18:10:50 +01:00
311b62e0ea Merge branch 'main' into Fix_T103397_v3
0e1a6f6033 Cleanup: Add in NLAStrip / NLATrack remove / clean methods
d42c803f5b Cleanup: add comment explaining #interpf is performing lerp
218a909dec GPencil: Fix unreported Eyedropper color difference in Materials
bea1eff3a5 Fix: No update setting curve selection domain with all selected
Compare 6 commits »
Clément Foucault commented on issue blender/blender#104285 2023-02-13 15:42:27 +01:00
Updated Matcaps with specular layer

I don't thnkk we should support metalic and roughness sliders for matcaps. The strength of the matcaps is that they are specific and consistent in their look. That is always at the cost of…

Clément Foucault commented on issue blender/blender#104640 2023-02-13 15:19:17 +01:00
MatCap Improvement

@JulienKaspar There is #104641 which should make the shadow follow the lighting.

Clément Foucault commented on issue blender/blender#104444 2023-02-13 14:50:41 +01:00
Rotation C++ API

I'll create a PR with the changes described here.

Clément Foucault commented on issue blender/blender#104285 2023-02-13 14:47:55 +01:00
Updated Matcaps with specular layer

I created #104640 with some thought on what should be a step forward into better handling the material system with matcap lighting.

It kind of overlap this task. To me, we should take the time…

Clément Foucault pushed to main at blender/blender 2023-02-13 12:50:07 +01:00
147c75b831 Cleanup: EEVEE-Next: Fix typo
0d9fbfe7fe GPUShader: Fix compilation caused by designated initializers in C++
Compare 2 commits »
Clément Foucault pushed to main at blender/blender 2023-02-13 12:19:09 +01:00
da0c182a61 Cycles: Fix compilation after recent GPU cleanups
Clément Foucault pushed to main at blender/blender 2023-02-13 11:22:52 +01:00
dd171f7743 Cleanup: GPUShader: Rename GPU_shader_uniform_vector
b68bac7ced Cleanup: GPUShader: Remove GPU_shader_uniform_int/float
173a8f4ac9 GPU: Removes GPU_shader_get_builtin_ssbo
164f591033 Cleanup: GPU: Rename some functions for consistency
83a6642045 Cleanup: GPU: Move eGPUKeyframeShapes to shader shared
Compare 9 commits »
Clément Foucault commented on pull request blender/blender#104536 2023-02-13 09:13:44 +01:00
Eevee: GPU Material node graph optimization.

typo

Clément Foucault commented on issue blender/blender#104640 2023-02-13 01:47:23 +01:00
MatCap Improvement

That's not what this task is about. That would be a workflow change and this task is only about cleaning up / improving existing matcap rendering.

Note that the different matcaps approach is…

Clément Foucault opened issue blender/blender#104644 2023-02-12 01:58:45 +01:00
BLF: Support GPU driven character stream