Clément Foucault fclem
29 Followers · 0 Following

  • I'm pixel pusher.

  • Joined on 2014-07-09
Repositories
3
 Projects Public Activity Starred Repositories
Clément Foucault pushed to metal-defines-cleanups at fclem/blender 2024-10-02 13:18:42 +02:00
20c5947bec Metal: Add atomic ops to sampler class
9feeeca6ac Metal: Use sampler template class instead of individual specialization
a75fb6dd78 Cleanup: Metal: Reduce name of samplers wrappers
14d1c27de3 Add array definition linting in glsl_preprocess
a7753660db Use array macro for array definition
Compare 7 commits »
Clément Foucault commented on pull request blender/blender#127514 2024-10-01 19:49:59 +02:00
EEVEE: Light & Shadow linking

The tests render fine, but some are crashing for some reason on my linux machine. They render fine with F12 render.

So I will check deeper tomorrow. But I think it is fine to commit anyway.

W…

Clément Foucault pushed to light-linking-no-resource-id at lateasusual/blender 2024-10-01 19:27:50 +02:00
10a504ea2e Merge branch 'main' into light-linking-no-resource-id
b4881f6b0a GPv3: Layer Tint Color, Radius Offset and Adjustments panel.
7b91f71ebf Grease Pencil: Move Layer selector and tool settings
92d00678ac macOS: Add Image Clipboard Copy/Paste Support
7ebe7a3b3b Fix #128200: Crash when duplicating essential brush asset
Compare 93 commits »
Clément Foucault pushed to light-linking-no-resource-id at lateasusual/blender 2024-10-01 19:16:33 +02:00
db8b1351fe Make it work
be6ac8e291 Shadow linking: Move UI panel to Blender
65c5b21d39 Fix UI showing cycles panel in EEVEE
81ecaac984 Silence warnings
d94ce28f6e Implement shadow linking using custom view visibility Class
Compare 9 commits »
Clément Foucault pushed to light-linking-no-resource-id at lateasusual/blender 2024-10-01 16:27:45 +02:00
416147b226 Use dupli parent for light set membership
Clément Foucault commented on pull request blender/blender#127514 2024-10-01 01:29:00 +02:00
EEVEE: Light & Shadow linking

The other issue is I don't think it works if receiver_light_set_get is in draw_shader_shared.hh, this makes shaders fail to compile (not certain but i think it's being included as typedef so…

Clément Foucault commented on pull request blender/blender#127514 2024-09-30 18:09:33 +02:00
EEVEE: Light & Shadow linking

I am going to implement the shadow linking tomorrow. It looks very simple and should come as one with light linking even.

@lateasusual BTW, why are you force pushing for every commit? It is a…

Clément Foucault pushed to light-linking-no-resource-id at lateasusual/blender 2024-09-30 18:05:09 +02:00
89a44f28a9 WIP of shadow linking
Clément Foucault commented on pull request blender/blender#128281 2024-09-30 17:29:55 +02:00
Fix #128164: Race condition in ShaderCreateInfo::finalize()

@blender-bot build

Clément Foucault commented on pull request blender/blender#128281 2024-09-30 17:07:35 +02:00
Fix #128164: Race condition in ShaderCreateInfo::finalize()

So you mean you are trying to prevent something from happening by mistake and that this mistake is not currently happening?

This is C++ good practice 101, I don't get the controversy.

I am…

Clément Foucault commented on pull request blender/blender#127514 2024-09-30 16:58:22 +02:00
EEVEE: Light & Shadow linking

Shouldn't it be receiver_light_set >= 32u ? and also shouldn't it be light_set_membership.x last? I see it is inverted inside eevee_light.cc too but that is confusing.

Clément Foucault pushed to main at blender/blender 2024-09-30 16:20:38 +02:00
fcc263162d Fix #128087: EEVEE: Position render pass not in viewport shading panel
Clément Foucault closed issue blender/blender#128087 2024-09-30 16:20:36 +02:00
EEVEE: Position render pass missing in viewport shading panel
Clément Foucault merged pull request blender/blender#128136 2024-09-30 16:20:35 +02:00
Fix #128087: EEVEE: Position render pass not in viewport shading panel
Clément Foucault approved blender/blender#128136 2024-09-30 16:19:57 +02:00
Fix #128087: EEVEE: Position render pass not in viewport shading panel
Clément Foucault commented on pull request blender/blender#128281 2024-09-30 16:19:07 +02:00
Fix #128164: Race condition in ShaderCreateInfo::finalize()

Yes I believe it should be separated. This fix is going to be backported and need to be isolated.

However, I don't see where exactly is the problem. If the base class was not called, we should…

Clément Foucault approved blender/blender#128281 2024-09-30 16:14:35 +02:00
Fix #128164: Race condition in ShaderCreateInfo::finalize()

While I am ok with this fix, it might be insufficient in the long run. But with the additional assert that seems same to have for now.

Clément Foucault commented on pull request blender/blender#128281 2024-09-30 16:11:16 +02:00
Fix #128164: Race condition in ShaderCreateInfo::finalize()

Is this still needed now?

Clément Foucault approved blender/blender#127995 2024-09-30 15:22:33 +02:00
Vulkan: Add support for VK_KHR_fragment_shader_barycentric

That looks good on my end.

Clément Foucault approved blender/blender#128142 2024-09-30 15:12:57 +02:00
Curves: Support View3DOverlay.display_handle property

Looks straightforward to me.