Clément Foucault fclem
29 Followers · 0 Following

  • I'm pixel pusher.

  • Joined on 2014-07-09
Repositories
3
 Projects Public Activity Starred Repositories
Clément Foucault merged pull request blender/blender#130468 2024-11-18 19:42:59 +01:00
Fix #130456: GP Render engine crash due to C/C++ mix
Clément Foucault approved blender/blender#130468 2024-11-18 19:42:34 +01:00
Fix #130456: GP Render engine crash due to C/C++ mix
Clément Foucault approved blender/blender#120999 2024-11-18 18:09:31 +01:00
Fix #113377: Pass edit mesh pointer through modifiers

Looks fine. Please test that it works for Overlay-Next too. We are in the process of making it default.

Clément Foucault pushed to main at blender/blender 2024-11-18 17:16:29 +01:00
7ca8a66a45 Fix: Overlay-Next: Fix uninitialized memory in some shape batches
Clément Foucault commented on pull request blender/blender#130336 2024-11-18 17:15:15 +01:00
Overlay-Next: Use submit_only

@blender-bot build

Clément Foucault approved blender/blender#130336 2024-11-18 17:15:04 +01:00
Overlay-Next: Use submit_only

Perfect! Thanks for taking the time to cleanup.

Clément Foucault commented on issue blender/blender#130456 2024-11-18 17:11:28 +01:00
Crash on files with Grease Pencil

I would like to understand why this is an issue only in release?

Clément Foucault suggested changes for blender/blender#130468 2024-11-18 17:10:16 +01:00
Fix #130456: GP Render engine crash due to C/C++ mix

I am fine with the proposed change. But you need to make sure the correct type is used for pass.push_constant("gpModelMatrix", &pd->object_bound_mat);. Do a manual cast there pass.push_constant("gpModelMatrix", float4x4(pd->object_bound_mat));

Clément Foucault deleted branch draw-handle-range from fclem/blender 2024-11-18 17:08:39 +01:00
Clément Foucault pushed to main at blender/blender 2024-11-18 17:08:36 +01:00
d4ac4f7b2d DRW: Make manager and passes allow range of handles
Clément Foucault merged pull request blender/blender#130290 2024-11-18 17:08:36 +01:00
DRW: Make manager and passes allow range of handles
Clément Foucault pushed to draw-handle-range at fclem/blender 2024-11-18 16:51:53 +01:00
8d15d1c4f2 Use ResourceHandleRange inside PassBase
Clément Foucault commented on pull request blender/blender#130290 2024-11-18 16:23:33 +01:00
DRW: Make manager and passes allow range of handles

@blender-bot build

Clément Foucault pushed to draw-handle-range at fclem/blender 2024-11-18 16:14:31 +01:00
6f2c393461 Merge branch 'main' into draw-handle-range
e8770a3845 Cleanup: Do not use PointerRNA::owner_id to create non-ID PointerRNAs.
1cd0ffd1d6 UI: Keymap Editor: Add margin from scrollbar
376f896b1f Cleanup: Overlay-Next: Use same test for V3D everywhere
fb6188f658 Fix: Overlay-Next: Crash when changing workspace
Compare 93 commits »
Clément Foucault commented on issue blender/blender#130464 2024-11-18 16:10:44 +01:00
Overlay: Speed-up grid drawing

I could also see the vertex count getting out of hand with longer clip ends and smaller grid scales.

IIRC the grids fades depending on their density. So the cost should be less than 1 vertex…

Clément Foucault pushed to main at blender/blender 2024-11-18 15:55:25 +01:00
376f896b1f Cleanup: Overlay-Next: Use same test for V3D everywhere
fb6188f658 Fix: Overlay-Next: Crash when changing workspace
cb1440b92f Fix: Overlay-Next: Wireframe does not update in sculpt mode
Compare 3 commits »
Clément Foucault opened issue blender/blender#130464 2024-11-18 15:46:18 +01:00
Overlay: Speed-up grid drawing
Clément Foucault commented on pull request blender/blender#119243 2024-11-18 14:45:45 +01:00
Nodes: Add new shader for node sockets

Note that, eventually, this should be shared with the shader code so that we don't have to cast and maintain both sides.

Think about moving it to GPU_shader_shared.hh to ease further cleanups.

Clément Foucault pushed to main at blender/blender 2024-11-18 14:42:41 +01:00
906e770b15 Fix: Overlay-Next: Object wireframe draw type not drawing wireframe
Clément Foucault pushed to main at blender/blender 2024-11-18 14:35:48 +01:00
3cad71b03f Fix: Overlay-Next: Grid occluding overlays in wireframe mode