Falk David filedescriptor

9 Followers · 0 Following

• Grease Pencil developer at Blender.

• Joined on 2017-01-04
• • 

Overview Repositories

6

Projects Public Activity Starred Repositories

1

Falk David commented on pull request blender/blender#129936 2024-11-07 13:44:42 +01:00

Fix #129873: GPv3: Missing material name overlay

@blender-bot build

Falk David approved blender/blender#129936 2024-11-07 13:43:55 +01:00

Fix #129873: GPv3: Missing material name overlay

Falk David commented on pull request blender/blender#129960 2024-11-07 13:42:56 +01:00

Fix #126076: GPv3: Strokes in multi-frame mode always use onion skinning colors

@blender-bot build

Falk David approved blender/blender#129960 2024-11-07 13:42:46 +01:00

Fix #126076: GPv3: Strokes in multi-frame mode always use onion skinning colors

Thanks, this works well!

Falk David suggested changes for blender/blender#129936 2024-11-07 13:36:03 +01:00

Fix #129873: GPv3: Missing material name overlay

Looks pretty good! One last comment.

Falk David commented on pull request blender/blender#129936 2024-11-07 13:36:02 +01:00

Fix #129873: GPv3: Missing material name overlay

Would be nice to get rid of the else bt returning in the if here:

Falk David suggested changes for blender/blender#129953 2024-11-07 13:02:15 +01:00

Fix: LineArt: Cache mechanism fixes

Falk David commented on pull request blender/blender#129953 2024-11-07 13:02:13 +01:00

Fix: LineArt: Cache mechanism fixes

const

Falk David commented on pull request blender/blender#129953 2024-11-07 13:02:12 +01:00

Fix: LineArt: Cache mechanism fixes

const

Falk David approved blender/blender#129955 2024-11-07 13:00:27 +01:00

Fix (unreported): GPv3: Incorrect user count for drawing at index 0

Thanks.

Falk David suggested changes for blender/blender#129936 2024-11-07 12:59:59 +01:00

Fix #129873: GPv3: Missing material name overlay

Tested this briefly and it seems to work like I expect it to.

Falk David commented on pull request blender/blender#129936 2024-11-07 12:59:58 +01:00

Fix #129873: GPv3: Missing material name overlay

Do:

Falk David commented on pull request blender/blender#129936 2024-11-07 12:59:57 +01:00

Fix #129873: GPv3: Missing material name overlay

Use for (const int point_i : points_by_curve[stroke_i]) {. No need for point_offset.

Falk David commented on pull request blender/blender#129936 2024-11-07 12:59:55 +01:00

Fix #129873: GPv3: Missing material name overlay

const float3 fpt = math::transform_point(object.object_to_world(), position);

Falk David commented on pull request blender/blender#129936 2024-11-07 12:59:54 +01:00

Fix #129873: GPv3: Missing material name overlay

comment style -> /* Don't show object extras in sets. */

Falk David commented on pull request blender/blender#129936 2024-11-07 12:59:53 +01:00

Fix #129873: GPv3: Missing material name overlay

Falk David approved blender/blender#129911 2024-11-07 12:42:20 +01:00

Fix #129183: Blender freezes permanently when pausing animation with multiframe on

This is fine for 4.2.

Falk David approved blender/blender#128080 2024-11-07 12:36:50 +01:00

Fix #125230: Issues when loading file with pinning gpencil brush material

Fine with me, will let @mont29 decide.

Falk David commented on pull request blender/blender#128080 2024-11-07 12:36:49 +01:00

Fix #125230: Issues when loading file with pinning gpencil brush material

Maybe this could use a comment as to why this is done.

Falk David commented on pull request blender/blender#129944 2024-11-07 12:34:31 +01:00

Fix: GPv3: "Only In Multiframe" overlay not working

@PratikPB2123 Maybe that should be a separate fix for blender/blender#126076