Falk David filedescriptor
  • Grease Pencil developer at Blender.

  • Joined on 2017-01-04
Falk David merged pull request blender/blender#129937 2024-11-07 10:30:08 +01:00
Fix #129907: Grease Pencil brush size gets stuck at 0
Falk David approved blender/blender#129937 2024-11-07 10:29:33 +01:00
Fix #129907: Grease Pencil brush size gets stuck at 0

Thanks! This makes sense to me.

Falk David created pull request blender/blender#129878 2024-11-05 19:11:53 +01:00
Fix #124725: GPv3: Masked layers not rendered correctly with onion skinning
Falk David created branch fix-124725 in filedescriptor/blender 2024-11-05 19:11:04 +01:00
Falk David pushed to fix-124725 at filedescriptor/blender 2024-11-05 19:11:04 +01:00
1ab0107252 Fix #124725: GPv3: Masked layers not rendered correctly with onion skinning
828f60b742 Fix check that only Control was pressed ignoring OsKey
fe8bc5100d Cleanup: Remove compilation warning
e071bf4690 Fix #129607: Armature "Assign to Collection" crashes with defaults
b53c20db25 EEVEE: remove DNA/RNA for values that are no longer in use
Compare 10 commits »
Falk David commented on issue blender/blender#125230 2024-11-05 16:22:55 +01:00
GPv3: Open a new scene after pin a material to brush, break material UI selector

There's potentially another way we could fix this, which is moving the local material into the library data-block of the brush, as indirectly linked. Then preserving it over file loads should…

Falk David commented on issue blender/blender#128270 2024-11-05 14:35:18 +01:00
Regression: GPv3: Primitives created with Ink Pen Rough brush aren't rough

Looking at the code, this would require larger changes. The new primitives were simply not built with this in mind. This will require some refactoring. I will lower the prioity for this since…

Falk David commented on pull request blender/blender#129860 2024-11-05 14:24:45 +01:00
Fix: GPv3: Some modifiers not working with non-poly curves

No need to rename this. convert_to_poly_curves was fine.

Falk David commented on pull request blender/blender#129860 2024-11-05 14:23:02 +01:00
Fix: GPv3: Some modifiers not working with non-poly curves

I think making the conversion explicit like Hans suggested is the right call here. This also makes it less error prone (like the issue I highlighted with the current outline modifier).

Falk David commented on pull request blender/blender#129860 2024-11-05 14:13:57 +01:00
Fix: GPv3: Some modifiers not working with non-poly curves

Ah, makes sense.

Falk David commented on pull request blender/blender#129860 2024-11-05 14:13:02 +01:00
Fix: GPv3: Some modifiers not working with non-poly curves

We have to be a bit careful here. This only works because the curves are modified in place in the drawing.

Falk David approved blender/blender#129789 2024-11-05 14:11:13 +01:00
Fix #129632: GPv3: Vgroup operation edits drawings from all keyframes

Seems to work great from a quick test, thanks!

Falk David commented on pull request blender/blender#129860 2024-11-05 14:08:39 +01:00
Fix: GPv3: Some modifiers not working with non-poly curves

I think it might make sense to add this above:

Falk David commented on pull request blender/blender#129789 2024-11-05 13:21:08 +01:00
Fix #129632: GPv3: Vgroup operation edits drawings from all keyframes

Hm this is getting very messy.