Falk David filedescriptor
  • Grease Pencil developer at Blender.

  • Joined on 2017-01-04
Falk David commented on pull request blender/blender#129789 2024-11-05 13:09:17 +01:00
Fix #129632: GPv3: Vgroup operation edits drawings from all keyframes

If we support multi-frame editing? Do we?

Falk David commented on issue blender/blender#129853 2024-11-05 13:07:42 +01:00
Calculate brush spacing relative to the scene makes blender stop working using drawing tablet with size pressure.

Might also be the 6% spacing which is very low.

Falk David commented on pull request blender/blender#129789 2024-11-05 12:45:30 +01:00
Fix #129632: GPv3: Vgroup operation edits drawings from all keyframes

Done. Though fix has become quite chaotic due to "vertex_group_remove_from" case. If you prefer I can create a separate PR for that

No that's fine imo.

Falk David suggested changes for blender/blender#129789 2024-11-05 12:45:16 +01:00
Fix #129632: GPv3: Vgroup operation edits drawings from all keyframes

Much better! Though I still think that it's best to pass in scene->r.cfra from the operators to the kernel functions rather than the entire scene.

Falk David commented on pull request blender/blender#129789 2024-11-05 12:45:15 +01:00
Fix #129632: GPv3: Vgroup operation edits drawings from all keyframes

Since we're not using the Scene and just the frame, it would be better to pass the frame into the function.

Falk David reopened issue blender/blender#121233 2024-11-05 12:39:48 +01:00
GPv3: Draw mode primitives are missing the use of MMB to confirm the stroke
Falk David commented on issue blender/blender#121233 2024-11-05 12:39:44 +01:00
GPv3: Draw mode primitives are missing the use of MMB to confirm the stroke

Since this seems like a pretty annoying regression, will reopen.

Falk David pushed to main at blender/blender 2024-11-05 12:30:15 +01:00
6cdac7bab8 Fix #129297: Gizmo missing for unlocked layer when autolock inactive is on
Falk David closed issue blender/blender#129297 2024-11-05 12:30:13 +01:00
Grease Pencil - Unlocking layer leads to no selection gizmo drawn while Autolock Inactive Layer is enabled
Falk David merged pull request blender/blender#129465 2024-11-05 12:30:11 +01:00
Fix #129297: Gizmo missing for unlocked layer when autolock inactive is on
Falk David approved blender/blender#129465 2024-11-05 12:29:18 +01:00
Fix #129297: Gizmo missing for unlocked layer when autolock inactive is on

Thanks. I think what I missed is that there is GreasePencil::set_active_layer which does call autolock_inactive_layers. Makes total sense now that we need to remove this from GreasePencil::set_active_node.

Falk David closed issue blender/blender#129798 2024-11-05 11:12:39 +01:00
Grease Pencil - Using "Selection to Cursor"-operator on non-poly type strokes doesn't immediately update geometry
Falk David merged pull request blender/blender#129848 2024-11-05 11:12:35 +01:00
Fix #129798: GPv3: Selection to Cursor/Grid missing immediate update
Falk David pushed to blender-v4.3-release at blender/blender 2024-11-05 11:12:34 +01:00
a3b04dffbc Fix #129798: GPv3: Selection to Cursor/Grid missing immediate update
Falk David closed issue blender/blender#129819 2024-11-05 10:36:43 +01:00
GPv3: Call menu shortcut doesn't work with all tools
Falk David pushed to blender-v4.3-release at blender/blender 2024-11-05 10:36:39 +01:00
334e9be8f4 Fix #129819: GPv3: Context menu for all paint tools
Falk David merged pull request blender/blender#129837 2024-11-05 10:36:38 +01:00
Fix #129819: GPv3: Context menu for all paint tools
Falk David commented on pull request blender/blender#129837 2024-11-05 10:26:38 +01:00
Fix #129819: GPv3: Context menu for all paint tools
Falk David approved blender/blender#129837 2024-11-05 10:26:24 +01:00
Fix #129819: GPv3: Context menu for all paint tools

Thanks, looks correct.