Campbell Barton ideasman42
  • Australia
  • Joined on 2005-01-30
Campbell Barton commented on pull request blender/blender#128818 2024-11-08 10:42:11 +01:00
UI: Move Preference Auto Close Pairs to Text Editor

Re-opening the PR since as Harley noted Pablo did not review yet.

Although as noted, I'd rather this be handled as a design that others can comment on first.

Campbell Barton commented on pull request blender/blender#128818 2024-11-08 10:40:10 +01:00
UI: Move Preference Auto Close Pairs to Text Editor

@Rawalanche the intent isn't to close, it's to move the discussion to a design task.

The fact people are making suggestions here for how this might work differently - or different ways we might…

Campbell Barton commented on pull request blender/blender#128818 2024-11-08 10:23:07 +01:00
UI: Move Preference Auto Close Pairs to Text Editor

We have a few preferences like this, which users might not even know exist yet might want easier access to them. This is closer to having things “just work” rather than having to tweak…

Campbell Barton commented on pull request blender/blender#128818 2024-11-08 08:23:34 +01:00
UI: Move Preference Auto Close Pairs to Text Editor

@Harley firstly we can always re-open the PR (if you feel strongly about this).

That this was discussed in meeting is fine but this was not proposed in a way others could comment on who were…

Campbell Barton pushed to main at blender/blender 2024-11-08 06:12:17 +01:00
5d9ac5ab86 Merge branch 'blender-v4.3-release'
759a9e5bcb Merge branch 'blender-v4.3-release'
c45d0cb022 Merge branch 'blender-v4.3-release'
67865cb73a Tests: add tests to ensure literal paths are properly handled
4be66511de Extensions: quote paths in error messages, improve missing file error
Compare 6 commits »
Campbell Barton closed issue blender/blender#129724 2024-11-08 06:12:15 +01:00
Cannot build an extension with non-empty paths
Campbell Barton pushed to blender-v4.3-release at blender/blender 2024-11-08 06:09:28 +01:00
67865cb73a Tests: add tests to ensure literal paths are properly handled
4be66511de Extensions: quote paths in error messages, improve missing file error
ae5f5c5bca Fix #129724: building extensions fails with non empty paths
Compare 3 commits »
Campbell Barton suggested changes for blender/blender#129999 2024-11-08 03:57:37 +01:00
Refactor: prevent storing dangling pointers

The current function signature makes it useful as a callback, even after this change almost all callers are passing null for the second argument or using wrapper functions.

Campbell Barton closed pull request blender/blender#128818 2024-11-08 01:49:43 +01:00
UI: Move Preference Auto Close Pairs to Text Editor
Campbell Barton commented on pull request blender/blender#128818 2024-11-08 01:49:39 +01:00
UI: Move Preference Auto Close Pairs to Text Editor
  • It's not communicated to the user which settings are preferences (and will impact other blender sessions).

  • This change doesn't scale.

    If we have 2-3 preferences we can fit them in a…

Campbell Barton pushed to pr-timeline-shortcut-fix at ideasman42/blender 2024-11-08 01:30:55 +01:00
67b01e0fa8 Minor correction to doc-string, include return type in related functions
Campbell Barton commented on pull request blender/blender#129841 2024-11-08 01:28:08 +01:00
Fix #129630: Inconsistent marker selection
Campbell Barton commented on pull request blender/blender#129841 2024-11-08 01:23:46 +01:00
Fix #129630: Inconsistent marker selection

Updated the PR, also moved the "Markers" key-map handler into wm_event_system.cc so it can be used by the check that excludes marker events.

Campbell Barton pushed to pr-timeline-shortcut-fix at ideasman42/blender 2024-11-08 01:21:53 +01:00
86c3755437 Move WM_event_handler_region_marker_poll into a shared function
f99675af47 Address comments from review
29d80b7499 Fix #129630: Inconsistent marker selection
5c880a5291 UI: Revert default brush icon to monochrome version
761f075f8d Fix #128280: GPv3: Realize instances doesn't copy grease pencil parameters
Compare 86 commits »
Campbell Barton commented on pull request blender/blender#129841 2024-11-08 00:55:13 +01:00
Fix #129630: Inconsistent marker selection

The code is currently scattered about, noted to check functions that use UI_MARKER_MARGIN_Y, but I think this is a candidate for a refactor that adds functions to return the rcti for the…

Campbell Barton commented on pull request blender/blender#129841 2024-11-08 00:38:15 +01:00
Fix #129630: Inconsistent marker selection

As it happens this declarations looks to be redundant (the header includes both declarations), but I'll leave cleanups out of this PR.

Campbell Barton commented on pull request blender/blender#129841 2024-11-08 00:31:08 +01:00
Fix #129630: Inconsistent marker selection

They're the same, renaming _test(..) to _poll(..).

Campbell Barton commented on issue blender/blender#129630 2024-11-08 00:11:56 +01:00
Markers selection seems inconsistent

From looking into this, some notes for the record:

Selection in animation/2D views uses fairly intricate logic to activate either: select-picking / tweak (select + translate) / box-select /…

Campbell Barton commented on issue blender/blender#128750 2024-11-07 08:59:49 +01:00
Extensions: Specify (optional) Python version on the server listing

Committed a3a3dda5632313d7f52231e2c2a54f4e36ed58a1.

When developing this I ended up having to make some changes the design proposed here.

The main difference is that a single extension can…

Campbell Barton pushed to main at blender/blender 2024-11-07 08:26:14 +01:00
d0a0133600 Merge branch 'blender-v4.3-release'
168cbca937 Cleanup: remove unused argument
c5272e7857 Cleanup: various non functional changes
a3a3dda563 Extensions: support for filtering based on Python versions
Compare 4 commits »