@ChrisLend as far as I can see we need to add back wireframe selection to support this use case. While it's not a trivial change I don't think it should be so difficult as the wire-frame drawing…
.orig
file added by accident
No need to be static, also, this can be assigned directly without assigning a variable (same for other declarations).
@JosephEagar The commit log states:
The first is that the code actually deliberately detects if nothing happened and pushed an undo step, a bugfix for a problem that no longer exists.
…
retval == OPERATOR_FINISHED
should be retval & OPERATOR_FINISHED
since operators can return `OPERATOR_FINISHED
In this case TextFormatType
can be used to split out file type checks, TextFormatType
can have a comment_prefix
callback added to support for different extension types.
Referring to ID properties here seems strange as not every caller assigns to ID properties, it would be enough to say the caller is responsible for setting the user.
All caller to BKE_vfont_load
need to be checked as some currently assume an additional user (the open font operator for e.g.).
This must have been a use-after-free mistake, double checked with the ob
argument removed and the tests now pass.
Please always give all the information you have when presenting a patch. Especially when it does not use things the way they are intended to.
My impression was this is using the API the way…
I'm aware of this and checked to make sure this wasn't happening
If you're aware that this code violates an existing design, that should be loudly warned about in the description, and…