Campbell Barton ideasman42
  • Australia
  • Joined on 2005-01-30
Campbell Barton pushed to main at blender/blender 2023-02-28 00:16:27 +01:00
e4f0e29bab Merge branch 'blender-v3.5-release'
de12ea7226 Cleanup: quiet unused warnings
d291955665 Fix setting the active vertex color when assigning false
Compare 3 commits »
Campbell Barton pushed to blender-v3.5-release at blender/blender 2023-02-28 00:10:36 +01:00
de12ea7226 Cleanup: quiet unused warnings
d291955665 Fix setting the active vertex color when assigning false
Compare 2 commits »
Campbell Barton commented on issue blender/blender#79024 2023-02-27 12:17:42 +01:00
2.83.2 and 2.9.0 problem with bone selection inside another bone

@ChrisLend as far as I can see we need to add back wireframe selection to support this use case. While it's not a trivial change I don't think it should be so difficult as the wire-frame drawing…

Campbell Barton pushed to main at blender/blender 2023-02-27 11:54:38 +01:00
f6c9fb27d5 Cleanup: remove .orig file added by accident
efb86b75ee Cleanup: comment block formatting
Compare 2 commits »
Campbell Barton pushed to main at blender/blender 2023-02-27 11:42:12 +01:00
f240a16037 Cleanup: format
9a1ab6bd14 Cleanup: function style casts for C++, use nullptr
347cbbff2d Fix path in check_licenses utility
Compare 3 commits »
Campbell Barton pushed to main at blender/blender 2023-02-27 11:02:09 +01:00
08af0f1204 Fix setting the active vertex color when assigning false
30db096cc8 Cleanup: quiet compiler warnings
dc08ff3c2e Cleanup: spelling in comments
Compare 3 commits »
Campbell Barton commented on pull request blender/blender#104953 2023-02-25 10:48:03 +01:00
Fix #104894: Text Editor: Toggle Comments: Consider language specification for comment prefix

No need to be static, also, this can be assigned directly without assigning a variable (same for other declarations).

Campbell Barton commented on issue blender/blender#104174 2023-02-24 07:44:15 +01:00
Regression: Clicking over empty viewport creates undo step in sculpt mode

@JosephEagar The commit log states:

The first is that the code actually deliberately detects if nothing happened and pushed an undo step, a bugfix for a problem that no longer exists.

Campbell Barton suggested changes for blender/blender#105065 2023-02-24 07:37:37 +01:00
Sequencer: Don't create undo step for empty box select

Noted request inline.

Campbell Barton commented on pull request blender/blender#105065 2023-02-24 07:33:48 +01:00
Sequencer: Don't create undo step for empty box select

retval == OPERATOR_FINISHED should be retval & OPERATOR_FINISHED since operators can return `OPERATOR_FINISHED

Campbell Barton suggested changes for blender/blender#104953 2023-02-24 07:26:52 +01:00
Fix #104894: Text Editor: Toggle Comments: Consider language specification for comment prefix

In this case TextFormatType can be used to split out file type checks, TextFormatType can have a comment_prefix callback added to support for different extension types.

Campbell Barton commented on pull request blender/blender#105126 2023-02-24 07:13:16 +01:00
WIP: Fix #100819: Delete one fake user for allocated vfont

Referring to ID properties here seems strange as not every caller assigns to ID properties, it would be enough to say the caller is responsible for setting the user.

Campbell Barton suggested changes for blender/blender#105126 2023-02-24 07:13:16 +01:00
WIP: Fix #100819: Delete one fake user for allocated vfont

All caller to BKE_vfont_load need to be checked as some currently assume an additional user (the open font operator for e.g.).

Campbell Barton commented on pull request blender/blender#104553 2023-02-21 12:12:10 +01:00
Use hash for Collection.gobject lookup, speedup object linking

This must have been a use-after-free mistake, double checked with the ob argument removed and the tests now pass.

Campbell Barton pushed to pr-collection-object-hash at ideasman42/blender 2023-02-21 11:44:35 +01:00
028b6e06a2 Experimental removal of object argument
Campbell Barton commented on pull request blender/blender#104801 2023-02-21 10:57:37 +01:00
Fix #104798: Slow frame-change & scrubbing with many objects

Please always give all the information you have when presenting a patch. Especially when it does not use things the way they are intended to.

My impression was this is using the API the way…

Campbell Barton commented on pull request blender/blender#104801 2023-02-21 10:29:05 +01:00
Fix #104798: Slow frame-change & scrubbing with many objects

I'm aware of this and checked to make sure this wasn't happening

If you're aware that this code violates an existing design, that should be loudly warned about in the description, and…