Campbell Barton ideasman42
  • Australia
  • Joined on 2005-01-30
Campbell Barton commented on pull request blender/blender#104410 2023-02-11 10:58:04 +01:00
Gizmo: add gizmos for spot and point light radius

While this works well, the relationship between the cursor motion & the lamp radius is off, although I think this relates to the gizmos modal function - so it could be handled separately.

Campbell Barton commented on pull request blender/blender#104410 2023-02-11 10:56:48 +01:00
Gizmo: add gizmos for spot and point light radius

Can be const.

Campbell Barton commented on issue blender/blender#104573 2023-02-11 07:18:29 +01:00
Re-design of submodules used in blender.git

I like most of the idea.

My only remark is that core functionality that happens to be implemented as add-ons (I/O mostly, but also OpenXR and Grease Pencil features) should be brought to…

Campbell Barton suggested changes for blender/blender#104418 2023-02-11 07:07:58 +01:00
Gizmo: press shift key to scale area lights uniformly

Using events from the gizmo group seems like it could back-fire in the future, see longer reply with alternative solution.

Campbell Barton commented on pull request blender/blender#104418 2023-02-11 07:06:58 +01:00
Gizmo: press shift key to scale area lights uniformly

While the functionality works well, this is handling events from the gizmo-group which may conflict with the gizmos event handling (in the future, even though it works now), as it means changes to…

Campbell Barton commented on pull request blender/blender#104581 2023-02-11 06:35:12 +01:00
Docs: improve online manual lookup time time

Turns out I was too quick to dismiss the approach from this patch, while checking for * isn't right, fnmatch is quite simple so a str.startswith check is valid as long as the string doesn't…

Campbell Barton suggested changes for blender/blender#104581 2023-02-11 06:14:26 +01:00
Docs: improve online manual lookup time time

As noted in reply, this will break support for some fnmatch features.

Campbell Barton commented on pull request blender/blender#104581 2023-02-11 06:11:14 +01:00
Docs: improve online manual lookup time time

This change only supports checks for the * character, fnmatch also supports characters within brackets & ?, so I don't think these kinds of optimizations are practical.

However 400ms for…

Campbell Barton pushed to main at blender/blender 2023-02-11 04:28:11 +01:00
6478eb565a Cleanup: format
Campbell Barton pushed to main at blender/blender 2023-02-11 04:24:31 +01:00
fefc6a73b3 Fix pep8 checker operating on dot-files
9f4edf8c2a Cleanup: remove unused variables
ce44953933 Cleanup: various C++ cleanups
Compare 3 commits »
Campbell Barton commented on pull request blender/blender#104453 2023-02-10 11:53:57 +01:00
Sequencer: Don't create undo step when click-select does nothing

Thanks, committed 5d30c3994e6ecf665bfae87d7294216d368f0c59, closing.

Campbell Barton closed pull request blender/blender#104453 2023-02-10 11:53:57 +01:00
Sequencer: Don't create undo step when click-select does nothing
Campbell Barton pushed to main at blender/blender 2023-02-10 11:53:27 +01:00
5d30c3994e Sequencer: Don't create undo step when click-select does nothing
Campbell Barton pushed to pr-104421-minor-update at ideasman42/blender 2023-02-10 09:53:51 +01:00
3d82ba7ad4 Minor tweaks to !104421
Campbell Barton pushed to pr-104421-minor-update at ideasman42/blender 2023-02-10 08:07:21 +01:00
00990114db Minor tweaks to !104421
Campbell Barton pushed to pr-104421-minor-update at ideasman42/blender 2023-02-10 08:04:12 +01:00
5b748ed160 Minor tweaks to !104421