Campbell Barton ideasman42
31 Followers · 0 Following
  • Australia
  • Joined on 2005-01-30
Repositories
5
 Projects Public Activity Starred Repositories
1
Campbell Barton suggested changes for blender/blender#104421 2023-02-10 07:42:56 +01:00
Fix: Incorrect BMesh to Mesh attribute copying

Generally this looks fine, noticed an issue (noted inline).

Campbell Barton commented on pull request blender/blender#104421 2023-02-10 07:42:56 +01:00
Fix: Incorrect BMesh to Mesh attribute copying

Appending a zeroed MeshToBMeshLayerInfo doesn't seem correct, the BMesh data should still be initialized so even if there is no source layer (where MeshToBMeshLayerInfo::mesh_data is NULL), the CustomData_data_set_default_value needs the bmesh_offset to be set. From what I can tell the other members should be set (type, elem_size) just not the mesh_data.

Campbell Barton created branch pr-104421-minor-update in ideasman42/blender 2023-02-10 07:32:03 +01:00
Campbell Barton pushed to pr-104421-minor-update at ideasman42/blender 2023-02-10 07:32:03 +01:00
e20d406f8a Minor tweaks to !104421
e635854a55 Squashed commit of the following:
Compare 2 commits »
Campbell Barton created pull request blender/blender#104553 2023-02-10 06:38:59 +01:00
Use hash for Collection.gobject lookup, speedup object linking
Campbell Barton pushed to pr-collection-object-hash at ideasman42/blender 2023-02-10 06:33:08 +01:00
9a1a473ffc Use hash for Collection.gobject lookup, speedup object linking
Campbell Barton pushed to pr-collection-object-hash at ideasman42/blender 2023-02-10 06:32:15 +01:00
e39861240b Use hash for Collection.gobject lookup, speedup object linking
3d0aa16ec0 Working
b77c82e2bb Tests: minor updates to make bl_rna_manual_reference more useful
c2c62c3618 RNA: return a dummy language value when WITH_INTERNATIONAL=OFF
a8d951abdd Docs: remove malformed patterns for RNA mapping
Compare 10 commits »
Campbell Barton created branch pr-collection-object-hash in ideasman42/blender 2023-02-10 06:32:15 +01:00
Campbell Barton commented on pull request blender/blender#104505 2023-02-10 04:25:54 +01:00
Fix #104026: Click-Drag to select graph editor channels no longer working

Tweaked the description. But I am unsure what about it wasn't following the guidelines.

The guidelines note:

Commit messages should use American English suitable for technical…

Campbell Barton pushed to main at blender/blender 2023-02-10 04:05:41 +01:00
b77c82e2bb Tests: minor updates to make bl_rna_manual_reference more useful
Campbell Barton pushed to main at blender/blender 2023-02-10 03:20:46 +01:00
c2c62c3618 RNA: return a dummy language value when WITH_INTERNATIONAL=OFF
a8d951abdd Docs: remove malformed patterns for RNA mapping
Compare 2 commits »
Campbell Barton pushed to main at blender/blender-dev-tools 2023-02-10 02:56:52 +01:00
2603fa7792 rna_manual_reference_updater: useful error if sphobjinv can't be found
3507e8a790 rna_manual_reference_updater: disallow malformed URL's
4ff8b58909 utils_doc/rna_manual_reference_updater: use bpy.utils.manual_locale_code
f38b20b9ea check_spelling_c: update dictionary
Compare 4 commits »
Campbell Barton deleted branch pr-pyapi-manual-fn from ideasman42/blender 2023-02-10 01:39:20 +01:00
Campbell Barton closed pull request blender/blender#104494 2023-02-10 01:38:23 +01:00
PyAPI: add bpy.utils.manual_locale_code(), use for "Help" menu
Campbell Barton commented on pull request blender/blender#104494 2023-02-10 01:38:22 +01:00
PyAPI: add bpy.utils.manual_locale_code(), use for "Help" menu

Committed, closing.

Campbell Barton pushed to main at blender/blender 2023-02-10 01:35:33 +01:00
4cbe0bff34 Cleanup: spelling in comments
48d9363fa7 Cleanup: quiet clang compiler warnings
8ac3096e24 Fix add-on & manual link in Help menu ignoring the current language
2ee9c12a23 PyAPI: add bpy.utils.manual_locale_code()
2d351e9ee3 Cleanup: format
Compare 5 commits »
Campbell Barton approved blender/blender#104484 2023-02-10 00:32:01 +01:00
I18n: write messages of the vertex group lock operator explicitly

Approving with one minor request.

Campbell Barton commented on pull request blender/blender#104484 2023-02-10 00:30:05 +01:00
I18n: write messages of the vertex group lock operator explicitly

It would be good to include a comment, adding context to why strings are handled this way.

Campbell Barton commented on issue blender/blender#104385 2023-02-10 00:06:05 +01:00
Viewport clipping in orthographic view

@o-k in that case I can't redo the problem.

  • Can you reproduce the error with factory-settings loaded.
  • Does the last pan operation that causes the clipping behave differently depending on…
Campbell Barton pushed to main at blender/blender 2023-02-09 13:43:12 +01:00
ca183993a5 Fix freeing uninitialized pointer in GHOST/Wayland + X11 fallback