This patch in it's current form doesn't seem to do anything useful.
This kind of information should be included in comments, also - importing then deleting from sys.modules is not great, committed 9fd71d470e5bebf12029acb770f3ab7620b418d3 to improve the…
In general avoid mixing in unrelated changes, it complicates review and means the reviewer needs to guess at why a change was made that isn't related to the patch description.
The intent was to…
The patch works well, all tests are passing.
@mattli911 best open a new report with exact details on what happens.
Also, be sure to check a daily build as well as the latest stable.
To avoid this use git commit -a instead of git commit ..
Checking the patch now (was there some review struggle-session going on? :) )
i thought it was a 3.4.1 problem, not a 3.3.3 problem.
apol extrud.blend is loading in Blender 3.4 and main branch. How do you make this fail?
Works well, my only concern is that none of these assignments are re-using existing memory where flags have existing values, where edge.flag = ME_EDGEDRAW; should be replaced by edge.flag = 0;…
Since this is intended to track change, this should only be set if the flags changed.
Many operators track changes, the convention is to name this changed.
This needs change should not be included.
Use C-style comments for comment blocks.