Update Steam/Windows Store to use blender-launcher #88613

New Issue

Ray molenkamp · 2021-05-27T04:25:06+02:00

Ray molenkamp commented

2021-05-27 04:25:06 +02:00

in blender/blender@f3944cf503 we added a new executable that launches blender without the annoying console window flashing in the users face.

When 3.0 gets released we need to update steam/windows store to launch blender-launcher.exe rather than blender.exe

in blender/blender@f3944cf503 we added a new executable that launches blender without the annoying console window flashing in the users face. When 3.0 gets released we need to update steam/windows store to launch blender-launcher.exe rather than blender.exe

Ray molenkamp commented

2021-05-27 04:25:06 +02:00

Added subscriber: @LazyDodo

blender-admin commented

2021-05-27 04:25:06 +02:00

blender/blender#100847 was marked as duplicate of this issue

James Monteath was assigned by Ray molenkamp

2021-05-27 04:27:20 +02:00

James Monteath commented

2021-05-27 07:13:33 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

James Monteath commented

2021-05-27 07:56:08 +02:00

I was able to add a new Launch Option for autotest-vdev branch so we can test.

{F10144341, size=720}

But not sure how we can target all the other branches and the default.
It seems that updating the current Launch Option 0, we would have to ensure the executable is deployed on all supported branches first.
{F10144346, size=720}

Or I would hope it is smart enough to try multiple options in a specified order.

I was able to add a new Launch Option for `autotest-vdev` branch so we can test. {[F10144341](https://archive.blender.org/developer/F10144341/image.png), size=720} But not sure how we can target all the other branches and the default. It seems that updating the current Launch Option 0, we would have to ensure the executable is deployed on all supported branches first. {[F10144346](https://archive.blender.org/developer/F10144346/image.png), size=720} Or I would hope it is smart enough to try multiple options in a specified order.

James Monteath commented

2021-05-27 07:57:39 +02:00

I will see if I can override this in the vdf at build time.

James Monteath commented

2021-05-27 08:04:31 +02:00

It would be great if we can also create Blender LTS apps instead of branches.
Then we can modify future short term releases without affecting LTS configurations.
We currently have LTS app Windows Store.

It would be great if we can also create Blender LTS apps instead of branches. Then we can modify future short term releases without affecting LTS configurations. We currently have LTS app Windows Store.

James Monteath commented

2021-05-27 08:39:01 +02:00

The new option is shown to the user.
I will rename the 2nd option for now so we can test.
{F10144405, size=720}

We will have to deploy this change to all supported branches, unless I can override per steam branch during build.

The new option is shown to the user. I will rename the 2nd option for now so we can test. {[F10144405](https://archive.blender.org/developer/F10144405/image.png), size=720} We will have to deploy this change to all supported branches, unless I can override per steam branch during build.

James Monteath commented

2021-05-27 08:46:55 +02:00

I pushed build to steam in autotest-vdev branch.
Works as expected, no pop up.
Seems quick to start also.

I pushed build to steam in `autotest-vdev` branch. Works as expected, no pop up. Seems quick to start also. ![image.png](https://archive.blender.org/developer/F10144411/image.png)

James Monteath commented

2021-05-27 09:06:11 +02:00

The MSI package looks good.

The MSI package looks good. ![image.png](https://archive.blender.org/developer/F10144433/image.png)

James Monteath removed their assignment 2021-09-07 10:29:04 +02:00

Francesco Siddi was assigned by James Monteath

2021-09-07 10:29:04 +02:00

James Monteath commented

2021-09-07 10:29:04 +02:00

Added subscriber: @ponderz

Francesco Siddi was unassigned by Dalai Felinto

2021-11-22 17:01:36 +01:00

Philipp Oeser was assigned by Dalai Felinto

2021-11-22 17:01:36 +01:00

Dalai Felinto commented

2021-11-22 17:01:36 +01:00

Added subscriber: @fsiddi

Brecht Van Lommel commented

2021-11-23 18:42:11 +01:00

Added subscriber: @brecht

Brecht Van Lommel commented

2021-11-23 18:42:11 +01:00

Since this is marked as planned for 3.0 and assigned to @lichtwerk, are we actually going to do this in the next week or leave it for later?

My understanding is that we have not tested this entirely, and it's also not clear to me how we intend to configure it. I'm guessing we would make blender-launcher.exe the default, and then add an entry for every older Blender steam branch with blender.exe too fall back. And hopefully there will be no popups then.

If we are going to do it, I think it should be done before release day, since there's nothing stopping it and we don't want problems while everyone is trying to upgrade. I don't think it's super important and we could leave it for later too.

Since this is marked as planned for 3.0 and assigned to @lichtwerk, are we actually going to do this in the next week or leave it for later? My understanding is that we have not tested this entirely, and it's also not clear to me how we intend to configure it. I'm guessing we would make blender-launcher.exe the default, and then add an entry for every older Blender steam branch with blender.exe too fall back. And hopefully there will be no popups then. If we are going to do it, I think it should be done before release day, since there's nothing stopping it and we don't want problems while everyone is trying to upgrade. I don't think it's super important and we could leave it for later too.

Philipp Oeser commented

2021-11-23 19:54:28 +01:00

I'll try to figure out the remaining questions tomorrow and arrange a "dry-run" (if at all possible).
Will get back with what I have by then (then there should still be enough time to decide if this should happen -- or pushed back).

I'll try to figure out the remaining questions tomorrow and arrange a "dry-run" (if at all possible). Will get back with what I have by then (then there should still be enough time to decide if this should happen -- or pushed back).

Philipp Oeser commented

2021-11-24 16:33:51 +01:00

Just to give you an update: to properly test this, I have set up a Win VM with Steam running (which took longer than expected for various reasons), so will continue tomorrow...

Philipp Oeser commented

2021-11-30 15:49:21 +01:00

Really sorry, looked into High prio bugs on thursday, but was also sick since Friday (still am), so time might be running short:

Windows Store:
- would have no idea how to do this there
Steam:
- new launch option is set up for the devtest-3.0 daily-3.0 & autotest-vdev branches now
- so if I understand correctly, this just means
  - 17 new launch options [set to blender.exe] (one for each of the 2.77 2.78 ... 2.83 2.83lts 2.90 ... 2.93 daily-2.83 daily-2.93 devtest-2.83 devtest-2.93 branches)
  - blender-launcher.exe goes to Launch option 0 (default)
  - [this is just hope] expect the 17 branches to not act up and automatically jump on the fallback option

Really sorry, looked into High prio bugs on thursday, but was also sick since Friday (still am), so time might be running short: - Windows Store: - would have no idea how to do this there - Steam: - new launch option is set up for the `devtest-3.0` `daily-3.0` & `autotest-vdev` branches now - so if I understand correctly, this just means - 17 new launch options [set to `blender.exe`] (one for each of the `2.77` `2.78` ... `2.83` `2.83lts` `2.90` ... `2.93` `daily-2.83` `daily-2.93` `devtest-2.83` `devtest-2.93` branches) - `blender-launcher.exe` goes to Launch option 0 (default) - [this is just hope] expect the 17 branches to not act up and automatically jump on the fallback option

Brecht Van Lommel commented

2021-11-30 16:50:16 +01:00

I think it's totally reasonable to leave this for after the 3.0 release if there's already too many things to deal with.

Windows Store: I think we change release/windows/msix/AppxManifest.xml.template in the Blender repository, replacing all occurrences of blender.exe by blender-launcher.exe. And then we'd test if installing the msix package generated by the buildbot (vXXX-code-store-windows) is working correctly.
Steam: yes, that's what I would try doing.

I think it's totally reasonable to leave this for after the 3.0 release if there's already too many things to deal with. * Windows Store: I think we change `release/windows/msix/AppxManifest.xml.template` in the Blender repository, replacing all occurrences of `blender.exe` by `blender-launcher.exe`. And then we'd test if installing the msix package generated by the buildbot (`vXXX-code-store-windows`) is working correctly. * Steam: yes, that's what I would try doing.

Philipp Oeser removed their assignment 2022-01-18 21:11:09 +01:00

Philipp Oeser commented

2022-01-18 21:11:09 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2022-01-18 21:11:09 +01:00

Will have to concentrate on triaging for a while (and step down).

Pratik Borhade commented

2022-08-17 02:09:03 +02:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2022-08-17 02:09:03 +02:00

3.2 won't receive any updates so moving this report to 3.3 project (or just keep BF Blender?)

3.2 won't receive any updates so moving this report to 3.3 project (or just keep `BF Blender`?)

Philipp Oeser commented

2022-09-06 12:11:52 +02:00

Added subscriber: @AMDphreak

Thomas Dinges commented

2022-11-14 16:45:27 +01:00

Added subscriber: @ThomasDinges

Philipp Oeser commented

2022-11-15 12:02:51 +01:00

The (fallback) launch options are now created for each of the branches < 3.0, will now test switching the Launch Option 0 over to blender-launcher.exe and see if everything still works properly...

The (fallback) launch options are now created for each of the branches < 3.0, will now test switching the `Launch Option 0` over to `blender-launcher.exe` and see if everything still works properly... ![fallback_lauch_options.png](https://archive.blender.org/developer/F13916768/fallback_lauch_options.png)

Philipp Oeser commented

2022-11-15 13:31:52 +01:00

OK, so turns out versions >= 3.0 would work just fine with blender-launcher.exe as the default Launch Option 0, but versions < 3.0 would (while giving you the option to launch with console) give an error complaining about missing blender-launcher.exe.

I left the alternate launch options in place in steam for now but switched back to the old behavior of just having blender.exe the default launch option.

Any ideas?

OK, so turns out versions >= 3.0 would work just fine with blender-launcher.exe as the default Launch Option 0, but versions < 3.0 would (while giving you the option to launch with console) give an error complaining about missing blender-launcher.exe. I left the alternate launch options in place in steam for now but switched back to the old behavior of just having blender.exe the default launch option. Any ideas?

Thomas Dinges commented

2022-11-15 13:34:23 +01:00

To clarify, the option for Blender versions < 3.0 is there, but the user would need to explicitly select the fallback (with console) option otherwise they get an error mesage.

Brecht Van Lommel commented

2022-11-15 13:56:14 +01:00

Does there have to be a default launch option, or can we make a single launch option for every branch?

Philipp Oeser commented

2022-11-15 15:02:04 +01:00

In #88613#1446204, @brecht wrote:
Does there have to be a default launch option, or can we make a single launch option for every branch?

OK, that seemed to have worked :)
So we now no longer have a default launcher option on steam, each branch has its own launcher option.
note to me and @ThomasDinges : we have to document this in the updated release checklist ("make sure to add a steam launcher option for a new steam branch")

> In #88613#1446204, @brecht wrote: > Does there have to be a default launch option, or can we make a single launch option for every branch? OK, that seemed to have worked :) So we now no longer have a default launcher option on steam, each branch has its own launcher option. note to me and @ThomasDinges : we have to document this in the updated release checklist ("make sure to add a steam launcher option for a new steam branch")

Brecht Van Lommel commented

2022-11-15 15:47:37 +01:00

Great.

The Windows store changes should also be quite simple? The main work is for someone to test the msix launches Blender correctly.

Great. The Windows store changes should also be quite simple? The main work is for someone to test the msix launches Blender correctly.

Thomas Dinges commented

2022-11-15 15:49:43 +01:00

For the Windows store we need to test this somehow. The .msix cannot be launched locally due to missing code signing. So I guess we need to make a "test" product to upload it to? Need to check this further.

Brecht Van Lommel commented

2022-11-15 16:01:25 +01:00

Can you install it like this?
https://learn.microsoft.com/en-us/windows/msix/package/unsigned-package#installing-an-unsigned-package

Can you install it like this? https://learn.microsoft.com/en-us/windows/msix/package/unsigned-package#installing-an-unsigned-package

Ray molenkamp commented

2022-11-15 21:18:43 +01:00

I can't reproduce locally but both on chat and on BA people are complaining about not being able to start blender from steam

https://blenderartists.org/t/i-cant-open-blender/1417042

I can't reproduce locally but both on chat and on BA people are complaining about not being able to start blender from steam https://blenderartists.org/t/i-cant-open-blender/1417042

Sun Kim commented

2022-11-16 08:28:31 +01:00

Added subscriber: @persun

Sun Kim commented

2022-11-16 08:28:31 +01:00

In #88613#1446479, @LazyDodo wrote:
I can't reproduce locally but both on chat and on BA people are complaining about not being able to start blender from steam

https://blenderartists.org/t/i-cant-open-blender/1417042

Also on Steam forums: https://steamcommunity.com/app/365670/discussions/0/6118730946118330032/

This error does not happen if you're opt in to a beta branch. I guess there's some error in launch configuration for latest stable build (3.3).

> In #88613#1446479, @LazyDodo wrote: > I can't reproduce locally but both on chat and on BA people are complaining about not being able to start blender from steam > > https://blenderartists.org/t/i-cant-open-blender/1417042 Also on Steam forums: https://steamcommunity.com/app/365670/discussions/0/6118730946118330032/ This error does not happen if you're opt in to a beta branch. I guess there's some error in launch configuration for latest stable build (3.3).

Thomas Dinges commented

2022-11-16 09:01:42 +01:00

Confirmed. Removing the default launcher option caused start issues on the main branch (when not opted in any beta / older release branch). I added the default launcher again, all older branches work fine but now show a dialog box with the "without console" option, which won't work for < Blender 3.0.

I don't see any good solutions on Steam.
Either we keep living with Blender > 3.0 opening with console or we remove all the old builds, keeping only 3.x ones (and the 2.93 LTS for the time being).

Confirmed. Removing the default launcher option caused start issues on the main branch (when not opted in any beta / older release branch). I added the default launcher again, all older branches work fine but now show a dialog box with the "without console" option, which won't work for < Blender 3.0. I don't see any good solutions on Steam. Either we keep living with Blender > 3.0 opening with console or we remove all the old builds, keeping only 3.x ones (and the 2.93 LTS for the time being).

Thomas Dinges commented

2022-11-16 09:29:23 +01:00

After further checking, I think we have the best solution now. Both the main option and all branches work. The only risk is that old branches (< 3.0) show launch options, where user can choose the "Without console" option, which then won't work and result in an error). But as long as people don't change this, it works.

The other two alternatives mentioned in my previous comment seem suboptimal to this. Since most people use new builds > 3.0 anyway, I think we should be okay.

After further checking, I think we have the best solution now. Both the main option and all branches work. The only risk is that old branches (< 3.0) show launch options, where user can choose the "Without console" option, which then won't work and result in an error). But as long as people don't change this, it works. The other two alternatives mentioned in my previous comment seem suboptimal to this. Since most people use new builds > 3.0 anyway, I think we should be okay.

Philipp Oeser commented

2022-11-16 09:31:51 +01:00

So current situation is:

Blender >= 3.0 launches without console (no popups) >> good
Blender < 3.0 launches with popup (one working option [with console] one broken option [without console]) >> less than optimal

Would still vote for keeping it like this (since the userbase for < 3.0 seems to be very small?)
{F13923835 size=full}

So current situation is: - Blender >= 3.0 launches without console (no popups) >> good - Blender < 3.0 launches with popup (one working option [with console] one broken option [without console]) >> less than optimal Would still vote for keeping it like this (since the userbase for < 3.0 seems to be very small?) {[F13923835](https://archive.blender.org/developer/F13923835/image.png) size=full}

Philipp Oeser commented

2022-11-16 09:50:58 +01:00

Just dropping here that there might be a problem left?

i can now use it through steam but steam doesnt seem to track time and not consider it an active game

https://steamcommunity.com/app/365670/discussions/0/6118730946118330032/?ctp=2#c3546050190319649233

Just dropping here that there *might* be a problem left? > i can now use it through steam but steam doesnt seem to track time and not consider it an active game https://steamcommunity.com/app/365670/discussions/0/6118730946118330032/?ctp=2#c3546050190319649233

Philipp Oeser commented

2022-11-16 10:39:13 +01:00

In #88613#1446688, @lichtwerk wrote:
Just dropping here that there might be a problem left?

i can now use it through steam but steam doesnt seem to track time and not consider it an active game

https://steamcommunity.com/app/365670/discussions/0/6118730946118330032/?ctp=2#c3546050190319649233

I assume to get rid of this, we might have to add the Launch Type Launch (Default) again which in turn would bring this back:

In #88613#1446183, @ThomasDinges wrote:
To clarify, the option for Blender versions < 3.0 is there, but the user would need to explicitly select the fallback (with console) option otherwise they get an error mesage.

So tradeoff between some nice (but niche? -- not sure if users really rely on their time being tracked, will ask in forums) bonus feature that steam brings OR a bit disturbing workflow [error by default] for a small userbase on blender < 3.0
None of the two seem like catastrophes, for now (until there are clear arguments for relying on the "steam-active-game-tracking") my vote would be to keep as-is.

> In #88613#1446688, @lichtwerk wrote: > Just dropping here that there *might* be a problem left? > >> i can now use it through steam but steam doesnt seem to track time and not consider it an active game > https://steamcommunity.com/app/365670/discussions/0/6118730946118330032/?ctp=2#c3546050190319649233 I assume to get rid of this, we might have to add the `Launch Type` `Launch (Default)` again which in turn would bring this back: > In #88613#1446183, @ThomasDinges wrote: > To clarify, the option for Blender versions < 3.0 is there, but the user would need to explicitly select the fallback (with console) option otherwise they get an error mesage. So tradeoff between some nice (but niche? -- not sure if users really rely on their time being tracked, will ask in forums) bonus feature that steam brings OR a bit disturbing workflow [error by default] for a small userbase on blender < 3.0 None of the two seem like catastrophes, for now (until there are clear arguments for relying on the "steam-active-game-tracking") my vote would be to keep as-is.

Ray molenkamp commented

2022-11-16 16:10:26 +01:00

The launcher exits as soon as blender.exe launches, so that's likely why steam can't keep track of the hours, we can likely add some code in the launcher to keep it around if it's steam launching it. there's already some code in it that keeps the launcher alive when you start it in background mode. shouldn't be too hard, the real question is do we want to?

The launcher exits as soon as `blender.exe` launches, so that's likely why steam can't keep track of the hours, we can likely add some code in the launcher to keep it around if it's steam launching it. there's already some code in it that keeps the launcher alive when you start it in background mode. shouldn't be too hard, the real question is do we want to?

Ray molenkamp commented

2022-11-16 16:51:48 +01:00

possible fix in D16527

possible fix in [D16527](https://archive.blender.org/developer/D16527)

Dong-Hyun Kim commented

2022-11-17 02:38:13 +01:00

Added subscriber: @temeddix

Dong-Hyun Kim commented

2022-11-17 02:38:13 +01:00

This comment was removed by @temeddix

*This comment was removed by @temeddix*

Philipp Oeser commented

2022-11-17 10:00:38 +01:00

In #88613#1446957, @LazyDodo wrote:
The launcher exits as soon as blender.exe launches, so that's likely why steam can't keep track of the hours, we can likely add some code in the launcher to keep it around if it's steam launching it. there's already some code in it that keeps the launcher alive when you start it in background mode. shouldn't be too hard, the real question is do we want to?

Ah, thx looking into this, good that my assumptions were wrong.
@LazyDodo : why would we not want to keep the launcher alive then?

> In #88613#1446957, @LazyDodo wrote: > The launcher exits as soon as `blender.exe` launches, so that's likely why steam can't keep track of the hours, we can likely add some code in the launcher to keep it around if it's steam launching it. there's already some code in it that keeps the launcher alive when you start it in background mode. shouldn't be too hard, the real question is do we want to? Ah, thx looking into this, good that my assumptions were wrong. @LazyDodo : why would we **not** want to keep the launcher alive then?

Thomas Dinges commented

2022-11-23 12:20:40 +01:00

I created a patch for the WIndows store now D16589, but not sure how to get an .msix for this to test. Build a patch build and then let the buildbot create an .msix for that? Arnd wasn't sure if that's possible.

I created a patch for the WIndows store now [D16589](https://archive.blender.org/developer/D16589), but not sure how to get an .msix for this to test. Build a patch build and then let the buildbot create an .msix for that? Arnd wasn't sure if that's possible.

Brecht Van Lommel commented

2022-11-23 13:23:31 +01:00

To test, just push the change to master and then test, it can't be done with a branch/patch build.

blender-admin commented

2022-11-23 15:14:13 +01:00

This issue was referenced by blender/blender@6e37f14489

This issue was referenced by blender/blender@6e37f14489e4eb4b08fa1ed3346c246128304a98

blender-admin commented

2022-11-23 15:14:13 +01:00

This issue was referenced by blender/blender@2124bfb211

This issue was referenced by blender/blender@2124bfb2113902b027fc5479c37e7c5425f626d2

blender-admin commented

2022-11-23 15:14:13 +01:00

This issue was referenced by blender/blender@460f7ec7aa

This issue was referenced by blender/blender@460f7ec7aacf23f391dacd7839c8c160679ad62d

Thomas Dinges commented

2022-11-24 10:50:52 +01:00

Added subscriber: @deadpin

Thomas Dinges commented

2022-11-24 10:50:52 +01:00

I couldn't verify the correctness of the change yet.

The command mentioned there only works starting on Windows 11, I am still on 10. https://learn.microsoft.com/en-us/windows/msix/package/unsigned-package#installing-an-unsigned-package
@deadpin tested it on Windows 11 (Thanks!), but got this error:
Add-AppPackage -Path .\blender-3.5.0-alpha+master.f4e1f62c62e6-windows.amd64-release.msix -AllowUnsigned
Add-AppxPackage: Deployment failed with HRESULT: 0x80073D2C, The package deployment failed because its publisher is not in the unsigned namespace.

I couldn't verify the correctness of the change yet. 1) The command mentioned there only works starting on Windows 11, I am still on 10. https://learn.microsoft.com/en-us/windows/msix/package/unsigned-package#installing-an-unsigned-package 2) @deadpin tested it on Windows 11 (Thanks!), but got this error: `Add-AppPackage -Path .\blender-3.5.0-alpha+master.f4e1f62c62e6-windows.amd64-release.msix -AllowUnsigned` `Add-AppxPackage: Deployment failed with HRESULT: 0x80073D2C, The package deployment failed because its publisher is not in the unsigned namespace.`

Brecht Van Lommel commented

2022-11-24 15:16:53 +01:00

Added subscriber: @Sergey

Brecht Van Lommel commented

2022-11-24 15:16:53 +01:00

@Sergey tested the msix here on Windows 11 (using local signing I think), and it seems to work as expected.

So now all that is left is backporting this to 3.4 and 3.3?

@Sergey tested the msix here on Windows 11 (using local signing I think), and it seems to work as expected. So now all that is left is backporting this to 3.4 and 3.3?

Thomas Dinges commented

2022-11-24 15:27:01 +01:00

Great, thanks for that. I will backport it to 3.4 and 3.3 and then close this task.