Prepare for running Gitea 1.21 release #66

New Issue

Arnd Marijnissen · 2023-07-31T15:24:35+02:00

Arnd Marijnissen commented

2023-07-31 15:24:35 +02:00

We should move to a newer release to fix:

Personal Access Tokens (PATs) cannot have a scope set
Pagination issues related to search-results ( #2)
LFS files missing in pull requests (#68)
Gitea sign out after closing browser (#70)
Missing syntax highlight in GLSL diffs (app.ini change)

The PATs issue is one that is preventing API-operations from being able to do anything useful/important. This has hit Sybren and TinyNick lately. With the work-around available, this is no major reason to upgrade (work-around involves disabling the 'display:none' in CSS using browser-inspector)

The second one is more 'pressing'.

If we are upgrading, we'll need to test our own modifications, but also be aware of some git-lfs config-changes that were being hinted at by Matti.

Note that at the time of writing, the Pagination pull-request ( https://github.com/go-gitea/gitea/pull/26012 ) has merged into main about 6 hours ago.

We should move to a newer release to fix: * [x] Personal Access Tokens (PATs) cannot have a scope set * [x] Pagination issues related to search-results ( #2) * [x] LFS files missing in pull requests (#68) * [x] Gitea sign out after closing browser (#70) * [x] Missing syntax highlight in GLSL diffs (app.ini change) The PATs issue is one that is preventing API-operations from being able to do anything useful/important. This has hit Sybren and TinyNick lately. With the work-around available, this is no major reason to upgrade (work-around involves disabling the 'display:none' in CSS using browser-inspector) The second one is more 'pressing'. If we are upgrading, we'll need to test our own modifications, but also be aware of some git-lfs config-changes that were being hinted at by Matti. Note that at the time of writing, the Pagination pull-request ( https://github.com/go-gitea/gitea/pull/26012 ) has merged into main about 6 hours ago.

🎉 1

Arnd Marijnissen added the

Type

Deployment

label 2023-07-31 15:24:46 +02:00

Arnd Marijnissen self-assigned this 2023-07-31 15:24:53 +02:00

Arnd Marijnissen commented

2023-08-07 13:55:51 +02:00

We've decided that we'll do a 1.20 release.
There's a working 1.20 in merged-develop which is lacking the pagination-feature currently.
For that, we'll ask if this can be merged into merged-develop

We've decided that we'll do a 1.20 release. There's a working 1.20 in merged-develop which is lacking the pagination-feature currently. For that, we'll ask if this can be merged into merged-develop

Arnd Marijnissen commented

2023-08-15 15:13:01 +02:00

Matti's attempted a backport of the pagination to 1.20; but that's failed to work.

Arnd good morning to you too. Yes, I have an answer for you. Sadly, the refactor was spread over a few PRs, which included relying on update code from other 1.21 PRs, so I wasn't able to backport. Good-ish news though, we will be entering feature freeze, and releasing an RC of 1.21 in a matter of weeks, so I know you want to go w/ 1.20.x because it is current stable version, but if you go w/ 1.21-dev you'll be ready for the coming release, which has the index refactor.

This means we would only solve the PAT-issue with a 1.20 deployment.
Given the projected release-date for 1.21 , we might reconsider. Will negotiate with the team.

Matti's attempted a backport of the pagination to 1.20; but that's failed to work. ``` Arnd good morning to you too. Yes, I have an answer for you. Sadly, the refactor was spread over a few PRs, which included relying on update code from other 1.21 PRs, so I wasn't able to backport. Good-ish news though, we will be entering feature freeze, and releasing an RC of 1.21 in a matter of weeks, so I know you want to go w/ 1.20.x because it is current stable version, but if you go w/ 1.21-dev you'll be ready for the coming release, which has the index refactor. ``` This means we would only solve the PAT-issue with a 1.20 deployment. Given the projected release-date for 1.21 , we might reconsider. Will negotiate with the team.

Arnd Marijnissen commented

2023-09-06 16:50:23 +02:00

Right now, I am aiming for a 1.21 deployment after having talked about it with some others.

Brecht Van Lommel changed title from ~~Prepare for running a 1.20.0-rc1 or later release~~ to Prepare for running Gitea 1.21 release

2023-10-20 17:04:29 +02:00

Brecht Van Lommel commented

2023-10-20 17:11:50 +02:00

The 1.21 release was delayed, but the current release candidate is expected to be the final one and it should be done soon.

blender-merged-develop was updated to match the release/v1.21 branch, and there is a gitea-1.21 branch for gitea-custom.

The 1.21 release was delayed, but the current release candidate is expected to be the final one and it should be done soon. `blender-merged-develop` was updated to match the `release/v1.21` branch, and there is a `gitea-1.21` branch for gitea-custom.

❤️ 1

Brecht Van Lommel commented

2023-10-30 18:52:33 +01:00

I think we area ready to do this now even though the release is not out yet. I understand it's just waiting for a blog post.

We may still decide to delay it until after 4.0 is out, to avoid interfering with the release. But we could update uatest already.

From what I could tell from the commits, there was no breaking config change that affects us. I did disable actions in the uatest app.ini since that got enabled by default. In principle it's not in the way so much, and people with their own runners could even use it for their own repositories. But still seems safer not to do this for now, until other public Gitea instances have production tested this more.

I think we area ready to do this now even though the release is not out yet. I understand it's just waiting for a blog post. We may still decide to delay it until after 4.0 is out, to avoid interfering with the release. But we could update uatest already. From what I could tell from the commits, there was no breaking config change that affects us. I did disable actions in the uatest `app.ini` since that got enabled by default. In principle it's not in the way so much, and people with their own runners could even use it for their own repositories. But still seems safer not to do this for now, until other public Gitea instances have production tested this more.

Arnd Marijnissen commented

2023-11-03 17:21:05 +01:00

I have been able to build and deploy the 1.21-updated version of blender-merged-develop on uatest.
The gitea-1.21 version of the styling template requires at least one minor adjustment but seems to generally work correctly.
Given that the 4.0 release has been delayed, this means that Pablo might find some time next week to address the styling update issues there might be and we'd be good to deploy short after the 4.0 release.
Releasing before 4.0 MIGHT be fine, but there might be some unforeseen side-effects, apart from losing the issues-index which is a known issue already.
Talked with brecht and pablo about all this; agreed is to go for 1.21 deploy shortly after blender 4's out the door.

I have been able to build and deploy the 1.21-updated version of blender-merged-develop on uatest. The gitea-1.21 version of the styling template requires at least one minor adjustment but seems to generally work correctly. Given that the 4.0 release has been delayed, this means that Pablo might find some time next week to address the styling update issues there might be and we'd be good to deploy short after the 4.0 release. Releasing before 4.0 MIGHT be fine, but there might be some unforeseen side-effects, apart from losing the issues-index which is a known issue already. Talked with brecht and pablo about all this; agreed is to go for 1.21 deploy shortly after blender 4's out the door.

Brecht Van Lommel commented

2023-12-01 19:02:48 +01:00

The upgrade is done.

Brecht Van Lommel closed this issue

2023-12-01 19:02:49 +01:00

Sign in to join this conversation.