infrastructure/extensions-website
4
8
Fork 10
Code Issues 20 Pull Requests 2 Projects Releases Wiki Activity

UI: fixes based on Actionable Feedback from devtalk and frontend changes #40

Merged
Pablo Vazquez merged 15 commits from martonlente/extensions-website:ui-alpha-launch-actionable-feedback into main 2024-02-27 16:05:54 +01:00
Conversation 0 Commits 15 Files Changed 7 +213 -39
Márton Lente commented 2024-02-26 12:55:14 +01:00
Owner
Copy Link

This PR will resolve issues listed in Actionable Feedback from devtalk, and Frontend sections in the following document: https://hackmd.io/@dfelinto/Sy31aRCUT

The PR has the following fixes and improvements:

  • There is no way to "remove" a preview image from the first time submission form
  • Allow to delete previews (from submission page)
  • Delete Extension (hide the button for now)
  • Reviews: "Not publicly visible" > "Awaiting approval"*
  • Reviews: After reviewing (while review is in moderation), the Be First to Review still shows*
  • Version History: Show the latest item expanded (similar to the LTS changelog)*
  • Links to have a more distinguishable look in the info panel (underlined)*
Screenshots

This PR improves Previews upload UI to match with existing admin UI patterns on the platform.
UI Alpha launch actionable feedback

*Some of the changes were resolved on main in the meanwhile. Conflicts were manually resolved, and changes were removed if needed.

This PR will resolve issues listed in _Actionable Feedback from devtalk,_ and _Frontend_ sections in the following document: https://hackmd.io/@dfelinto/Sy31aRCUT The PR has the following fixes and improvements: - [x] There is no way to "remove" a preview image from the first time submission form - [x] Allow to delete previews (from submission page) - [x] Delete Extension (hide the button for now) - [x] Reviews: "Not publicly visible" > "Awaiting approval"* - [x] Reviews: After reviewing (while review is in moderation), the Be First to Review still shows* - [x] Version History: Show the latest item expanded (similar to [the LTS changelog](https://www.blender.org/download/lts/3-3/))* - [x] Links to have a more distinguishable look in the info panel (underlined)* ###### Screenshots This PR improves Previews upload UI to match with existing admin UI patterns on the platform. ![UI Alpha launch actionable feedback](https://projects.blender.org/attachments/815beadd-052d-46e5-a619-a848e2d07f4f) *Some of the changes were resolved on main in the meanwhile. Conflicts were manually resolved, and changes were removed if needed.
ui-alpha-launch-actionable-feedback-1.png
131 KiB
Márton Lente added 1 commit 2024-02-26 12:55:16 +01:00
Márton Lente added 1 commit 2024-02-26 12:56:33 +01:00 
Part of #40
Márton Lente added 1 commit 2024-02-26 13:04:45 +01:00 
Part of #40
Márton Lente added 1 commit 2024-02-26 14:00:45 +01:00 
Part of #40
Márton Lente changed title from WIP: UI fixes based on Actionable Feedback from devtalk to WIP: UI fixes based on Actionable Feedback from devtalk and frontend changes 2024-02-26 14:13:08 +01:00
Márton Lente added 1 commit 2024-02-26 15:37:31 +01:00 
Part of #40
Márton Lente added 1 commit 2024-02-26 15:51:11 +01:00 
Part of #40
Márton Lente added 1 commit 2024-02-26 15:58:12 +01:00 
Part of #40
Márton Lente added 1 commit 2024-02-26 18:35:08 +01:00 
Part of #40
Márton Lente added 1 commit 2024-02-26 19:09:34 +01:00 
Part of #40
Márton Lente added 2 commits 2024-02-26 20:29:13 +01:00 
Part of #40
Part of #40
Márton Lente added 1 commit 2024-02-27 10:32:25 +01:00 
Part of #40
Márton Lente added 1 commit 2024-02-27 11:02:34 +01:00 
Part of #40
Márton Lente added 1 commit 2024-02-27 11:07:52 +01:00 
Part of #40
Márton Lente added 1 commit 2024-02-27 12:13:36 +01:00
Márton Lente changed title from WIP: UI fixes based on Actionable Feedback from devtalk and frontend changes to UI: fixes based on Actionable Feedback from devtalk and frontend changes 2024-02-27 12:26:18 +01:00
Pablo Vazquez approved these changes 2024-02-27 16:04:43 +01:00
common/static/common/styles/_extension.sass Outdated
@ -119,2 +119,4 @@
a
overflow: hidden
// TODO: consider changing text-decoration underlines to border-bottoms for improved, more spatious vertical spacings
text-decoration: underline
Pablo Vazquez commented 2024-02-26 15:02:33 +01:00
Owner
Copy Link

This can be discarded as it is implemented already.

This can be discarded as it is implemented already.
extensions/templates/extensions/version_list.html Outdated
@ -24,3 +24,3 @@
{% for version in extension.versions.exclude_deleted %}
{% if version.is_listed or is_maintainer %}
<details>
<details {% if forloop.first %}open=""{% endif %}>
Pablo Vazquez commented 2024-02-26 15:02:54 +01:00
Owner
Copy Link

This can be discarded as it is implemented already.

This can be discarded as it is implemented already.
👍 1
Pablo Vazquez merged commit 709b3e1b36 into main 2024-02-27 16:05:54 +01:00
Pablo Vazquez deleted branch ui-alpha-launch-actionable-feedback 2024-02-27 16:05:54 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Pablo Vazquez
Labels
Clear labels   
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Normal
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Type
Breaking
Breaking change that won't be backward compatible

  
Type
Documentation
Documentation changes

  
Type
Enhancement
Improve existing functionality

  
Type
Feature
New functionality

  
Type
Report
Something is not working

  
Type
Security
This is security issue

  
Type
Suggestion
New ideas and proposals

  
Type
Testing
Issue or pull request related to testing

No Label
Priority
Critical
Priority
High
Priority
Low
Priority
Normal
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Type
Breaking
Type
Documentation
Type
Enhancement
Type
Feature
Type
Report
Type
Security
Type
Suggestion
Type
Testing
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/extensions-website#40
No description provided.
Delete Branch "martonlente/extensions-website:ui-alpha-launch-actionable-feedback"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?