infrastructure/extensions-website
4
8
Fork 10
Code Issues 20 Pull Requests 2 Projects Releases Wiki Activity

Reuse existing files as previews, icons or featured images #161

Merged
Anna Sirota merged 11 commits from files-allow-reuse-between-ext into main 2024-06-04 12:23:26 +02:00
Conversation 0 Commits 11 Files Changed 17 +4 -1
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 7235956988 - Show all commits

5
extensions/signals.py
View File

@ -34,7 +34,10 @@ def _delete_version_file(
sender: object, instance: extensions.models.Version, **kwargs: object sender: object, instance: extensions.models.Version, **kwargs: object
) -> None: ) -> None:
# **N.B.**: this isn't part of an overloaded `Version.delete()` method because # **N.B.**: this isn't part of an overloaded `Version.delete()` method because
# that method isn't called when `Extension.delete()` cascades to deleting the versions. # that method isn't called when `Extension.delete()` cascades to deleting the versions:
#
# delete() method for an object is not necessarily called ... as a result of a cascading delete
# https://docs.djangoproject.com/en/4.2/topics/db/models/#overriding-predefined-model-methods
version_file = instance.file version_file = instance.file
logger.info('Deleting file pk=%s of Version pk=%s', version_file.pk, instance.pk) logger.info('Deleting file pk=%s of Version pk=%s', version_file.pk, instance.pk)
version_file.delete() version_file.delete()