infrastructure/extensions-website
4
8
Fork 10
Code Issues 20 Pull Requests 2 Projects Releases Wiki Activity

Fix deletion task, protect more account-linked data #165

Manually merged
Anna Sirota merged 11 commits from fix-account-deletion into main 2024-06-05 13:24:50 +02:00
Conversation 0 Commits 11 Files Changed 12 +359 -39
Anna Sirota commented 2024-06-04 11:23:04 +02:00
Owner
Copy Link

Account deletion task had a bug in it: its was skipping all accounts that were deactivated, but accounts are deactivated as soon as date_deletion_requested is received via webhook.

In addition to fixing that (now the task will exclude all account records that look like they were already anonymized), this also changes several on delete properties:

  • abuse reports about a deleted account are deleted along with it;
  • abuse reports made by a deleted account remain;
  • ratings made by a deleted account remain;
  • approval activity protects against deletion: account cannot be deleted if it authored any approval activity;

This PR also makes sure that API tokens and OAuth info/tokens are deleted when account is anonymized as well.

Account deletion task had a bug in it: its was skipping all accounts that were deactivated, but accounts are deactivated as soon as `date_deletion_requested` is received via webhook. In addition to fixing that (now the task will exclude all account records that look like they were already anonymized), this also changes several on delete properties: * abuse reports about a deleted account are deleted along with it; * abuse reports **made** by a deleted account remain; * ratings made by a deleted account remain; * approval activity protects against deletion: account cannot be deleted if it authored any approval activity; This PR also makes sure that API tokens and OAuth info/tokens are deleted when account is anonymized as well.
Anna Sirota added 1 commit 2024-06-04 11:23:05 +02:00
Anna Sirota changed title from WIP: Enable deletion task, protect more account-linked data to WIP: Fix deletion task, protect more account-linked data 2024-06-04 11:23:15 +02:00
Anna Sirota added 2 commits 2024-06-04 11:40:01 +02:00
Anna Sirota added 1 commit 2024-06-04 11:41:30 +02:00
Anna Sirota added 7 commits 2024-06-05 12:14:12 +02:00
Anna Sirota changed title from WIP: Fix deletion task, protect more account-linked data to Fix deletion task, protect more account-linked data 2024-06-05 13:19:28 +02:00
Anna Sirota manually merged commit 729ce453ac into main 2024-06-05 13:24:50 +02:00
Anna Sirota deleted branch fix-account-deletion 2024-06-05 13:25:31 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Normal
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Type
Breaking
Breaking change that won't be backward compatible

  
Type
Documentation
Documentation changes

  
Type
Enhancement
Improve existing functionality

  
Type
Feature
New functionality

  
Type
Report
Something is not working

  
Type
Security
This is security issue

  
Type
Suggestion
New ideas and proposals

  
Type
Testing
Issue or pull request related to testing

No Label
Priority
Critical
Priority
High
Priority
Low
Priority
Normal
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Type
Breaking
Type
Documentation
Type
Enhancement
Type
Feature
Type
Report
Type
Security
Type
Suggestion
Type
Testing
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/extensions-website#165
No description provided.
Delete Branch "fix-account-deletion"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?