Anna Sirota
caae613747
* removes all soft-deletion; * shows a "Delete extension" button on the draft page in case it can be deleted; * shows a "Delete version" button on the version page in case it can be deleted; * a version can be deleted if * its file isn't approved, and it doesn't have any ratings; * an extension can be deleted if * it's not listed, and doesn't have any ratings or abuse reports; * all it's versions can also be deleted; * changes default `File.status` from `APPROVED` to `AWAITING_REVIEW` With version's file status being `APPROVED` by default, a version can never be deleted, even when the extension is still a draft. This change doesn't affect the approval process because * when an extension is approved its latest version becomes approved automatically (no change here); * when a new version is uploaded to an approved extension, it's approved automatically (this is new). This allows authors to delete their drafts, freeing the extension slug and making it possible to re-upload the same file. This also makes it possible to easily fix mistakes during the drafting of a new extension (e.g. delete a version and re-upload it without bumping a version for each typo/mistake in packaging and so on). (see #78 and #63) Reviewed-on: #81
40 lines
1.2 KiB
Python
40 lines
1.2 KiB
Python
import logging
|
|
|
|
from django.db.models.signals import pre_save, post_save, pre_delete
|
|
from django.dispatch import receiver
|
|
|
|
import files.models
|
|
import files.tasks
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
|
@receiver(pre_save, sender=files.models.File)
|
|
def _record_changes(
|
|
sender: object, instance: files.models.File, update_fields: object, **kwargs: object
|
|
) -> None:
|
|
was_changed, old_state = instance.pre_save_record(update_fields=update_fields)
|
|
|
|
instance.record_status_change(was_changed, old_state, **kwargs)
|
|
|
|
|
|
def schedule_scan(file: files.models.File) -> None:
|
|
"""Schedule a scan of a given file."""
|
|
logger.info('Scheduling a scan for file pk=%s', file.pk)
|
|
files.tasks.clamdscan(file_id=file.pk, creator=file, verbose_name=file.source.name)
|
|
|
|
|
|
@receiver(post_save, sender=files.models.File)
|
|
def _scan_new_file(
|
|
sender: object, instance: files.models.File, created: bool, **kwargs: object
|
|
) -> None:
|
|
if not created:
|
|
return
|
|
|
|
schedule_scan(instance)
|
|
|
|
|
|
@receiver(pre_delete, sender=files.models.File)
|
|
def _log_file_delete(sender: object, instance: files.models.File, **kwargs: object) -> None:
|
|
logger.info('Deleting file pk=%s source=%s', instance.pk, instance.source.name)
|