@JacquesLucke I've reorganized code, it is still in IndexMasks.
BEZIER_HANDLE_AUTO handles are affected by selection of both left and right sides and it leads to the choice between…
@JacquesLucke I remembered, main argument to use masks was contains.
It is needed if to loop over points. I'll try to simplify things by using less masks and pushing logic into `IndexMask::from…
While it's nice to use
IndexMaskwhere possible, it does feel like this adds lots of unnecessary complexity here.. It seems like just iterating over the bezier curves and updating them in a…
Haven't looked at the code in too much detail yet. It seems the behavior is still different compared to legacy curves. When I start with auto handles, I can grab them freely on legacy curves,…
It does and it works after small fix.
But call like handle_types_left_for_write creates new attribute in curves and that is unnecessary side effect.
I refuse to check or believe that this…
I've refactored the code.
// Could even be part of the transform context...
Good point. I'll move them when #128638 is merged to avoid conflicts.
That is relieving, I had a feeling I understand less and less :)
The logic in old curves is different. It is described in PR. If I imagine right, this asimetric approach would allow to move two handles and leave knot in place, making a corner.
Regarding…
I jumped rewriting and it appeared that TransCustomData holds only selected points. Adding them would complicate things too much.
Again why it will be better to make a copy and then call…
& is severe bug, but with const another story.
Some say that it is redundant, but others use that style:
https://projects.blender.org/blender/blender/src/commit/de5ac7395e3ae4e5e5a698996aff6e…
It seems that most reasonable way to do alignment in TransCustomData before calls to copy_positions_from_curves_transform_custom_data.