Laurynas Duburas laurynas
  • Joined on 2021-06-10
Laurynas Duburas commented on pull request blender/blender#128726 2024-10-10 20:14:30 +02:00
Curves: Align handles in transform operator

After checking curves_geometry.cc even selection isn't that attractive.

de5ac7395e/source/blender/blenk

Laurynas Duburas commented on pull request blender/blender#128726 2024-10-10 20:04:57 +02:00
Curves: Align handles in transform operator

With selection agree, but method name I'd keep verb. Maybe calculate_aligned_handles to keep consistency with calculate_auto_handles?

Laurynas Duburas commented on issue blender/blender#99891 2024-10-09 16:55:13 +02:00
Support custom NURBS knot vectors

NURBS knot vector storage in the Point domain proposal.

shrink_knots.png To explain it is easiest to start from clamped (Endpoint) non…

Laurynas Duburas deleted branch curves-handle-display2 from laurynas/blender 2024-10-08 21:18:58 +02:00
Laurynas Duburas pushed to curves-handle-display2 at laurynas/blender 2024-10-08 20:57:06 +02:00
0d61ef88c7 make format
Laurynas Duburas commented on pull request blender/blender#128142 2024-10-08 16:43:50 +02:00
Curves: Support View3DOverlay.display_handle property

Can someone merge this into main?

Laurynas Duburas pushed to curves-handle-display2 at laurynas/blender 2024-10-08 16:35:23 +02:00
0a51e62270 Merge branch 'main' into curves-handle-display2
8bc89c5236 Fix #128714: GPv3: Don't erase behind the camera
f093e4ad44 Refactor: remove the 'New Slot for Object' operator
411f399a7f Anim: disable 'New Slot' operator on linked Actions
0156b38905 Merge branch 'blender-v4.3-release'
Compare 577 commits »
8f718086a1 readability
Laurynas Duburas created pull request blender/blender#128726 2024-10-07 23:16:26 +02:00
Curves: align handles
Laurynas Duburas pushed to curves-align-handles at laurynas/blender 2024-10-07 22:53:19 +02:00
b9cdb93a56 Curves: align handles
66697cb81e Merge branch 'blender-v4.3-release'
bacbed14d0 Fix #128595: Mesh Filter Erase Displacement crashes without multires
207150affe Merge branch 'blender-v4.3-release'
983ef262d8 Fix #128618: Crash when using cloth brush and automasking
Compare 10 commits »
Laurynas Duburas created branch curves-align-handles in laurynas/blender 2024-10-07 22:53:19 +02:00
Laurynas Duburas commented on pull request blender/blender#128638 2024-10-07 22:17:50 +02:00
Curves: Convert types when transforming

Actually I have types per point. It is curves.handle_types_left() or curves.handle_types_right(). What I don't have is const std::array<int, CURVE_TYPES_NUM> &type_counts.

Laurynas Duburas commented on pull request blender/blender#128638 2024-10-07 21:18:57 +02:00
Curves: Convert types when transforming

When curves don't have Bezier curves, then there are no left, right handles and their selection attributes. Usually it is checked by ed::curves::get_curves_selection_attribute_names(curves),…

Laurynas Duburas commented on pull request blender/blender#128638 2024-10-07 21:05:57 +02:00
Curves: Convert types when transforming

Ok. You right here.

c87e485c6e code readability
Laurynas Duburas commented on pull request blender/blender#128638 2024-10-07 20:06:29 +02:00
Curves: Convert types when transforming

50 lines of code for free? I was in doubt of this check if (must_be_selected_mask.size()) { and still left it :)

Laurynas Duburas commented on pull request blender/blender#128638 2024-10-07 20:01:06 +02:00
Curves: Convert types when transforming

I don't get what you are suggesting here.

Here I'm building mask for points that belong to Bezier curves ignoring selection status. These are needed to check handle types only for Bezier…

Laurynas Duburas commented on pull request blender/blender#128638 2024-10-07 19:43:53 +02:00
Curves: Convert types when transforming

If I knew where to types per point then yes.

Laurynas Duburas commented on pull request blender/blender#128638 2024-10-07 19:33:52 +02:00
Curves: Convert types when transforming

Yes. Otherwise body offor (const int side : IndexRange(handle_types.size())) { would be duplicated also twice as much variable names.

Laurynas Duburas commented on pull request blender/blender#128638 2024-10-07 19:28:49 +02:00
Curves: Convert types when transforming

indices_for_type give curve indices, here points are needed.