After checking curves_geometry.cc
even selection
isn't that attractive.
With selection
agree, but method name I'd keep verb.
Maybe calculate_aligned_handles
to keep consistency with calculate_auto_handles
?
Actually I have types per point. It is curves.handle_types_left()
or curves.handle_types_right()
.
What I don't have is const std::array<int, CURVE_TYPES_NUM> &type_counts
.
When curves
don't have Bezier curves, then there are no left, right handles and their selection attributes.
Usually it is checked by ed::curves::get_curves_selection_attribute_names(curves)
,…
50 lines of code for free?
I was in doubt of this check if (must_be_selected_mask.size()) {
and still left it :)
I don't get what you are suggesting here.
Here I'm building mask for points that belong to Bezier curves ignoring selection status. These are needed to check handle types only for Bezier…
Yes. Otherwise body offor (const int side : IndexRange(handle_types.size())) {
would be duplicated also twice as much variable names.
indices_for_type
give curve indices, here points are needed.