This report does not contain all the requested information, which is required for us to investigate the issue.
Please submit a new report and carefully follow the instructions. Be sure to…
We have a group icon first in the list, this icon is added by the first statement in the sequence in this function, current one is about custom nodes. Probably first one statement need to be…
Probably this should be parallel_reduce. Otherwise, consider idea of use task_hint to make granulation smarter for begin elements with N complexity (basicaly just (range.projverts() - range.start()) * range.size() in accumulative mode).
Greiner Hormann algorithm.
+Pass const args first (even if const will be in .cc file only)
Greiner Hormann algorithm.
result.verts.reinitialize(curve.size())
Greiner Hormann algorithm.
It's very helpful to split the code into phases but please, make separation between phases as different functions with meaningful names what is happening on caller.
Greiner Hormann algorithm.
Please do return anything meaningful about the doned one, this just unnecessary hide actual code by meaningless function abstraction. Trying to follow code style from the paper alos does no holds a lot for anyone other.
Greiner Hormann algorithm.
static BooleanResult curve_to_result(const Span<float2> curve)
Greiner Hormann algorithm.
This should be in the header of the whole file imo.
Greiner Hormann algorithm.
Use switch statement for any such case-trees/
Greiner Hormann algorithm.
Do not add const in the header for trivial types.
Greiner Hormann algorithm.
Can we just swap arguments on caller to avoid such case to be in api?
Greiner Hormann algorithm.
Weight is not needed, just call .finalize() after all mixing.
Greiner Hormann algorithm.
So, you can just did 2 loop pass with i and mod(i + 1), but here is one loop with 3 switch and mod(i + 1) for each element?