Iliya Katushenock mod_moder
  • Russian
  • Just student

  • Joined on 2019-01-20
Iliya Katushenock commented on pull request blender/blender#127184 2024-09-05 17:28:39 +02:00
Fix #127054: crash due to integer overflow in Resample Curves node

Does this mean that result of overflow, converted to smaller int, will be just max int (crash due to not enough memory) or int will be clipped by lower bytes (incorrect offset indices invariant -…

Iliya Katushenock commented on issue infrastructure/blender-projects-platform#122 2024-09-05 17:21:02 +02:00
Gitea: Add new custom emojis

My current suggestion is to add the new icons as emoji:

  1. Cake. 2 Sweet Smile.
  2. House Fire.

Wonder is SVG is supported or icons should be done as png pictures?/

Iliya Katushenock commented on pull request blender/blender#127128 2024-09-04 21:12:28 +02:00
UI: Use a Vector to store buttons in UI blocks

Seems like its better to do:

Iliya Katushenock commented on issue blender/blender#126949 2024-09-04 18:16:35 +02:00
Regression: Geometry nodes - instances and boolean operation bug

@mod_moder Blender should not crash even if there is a dependency cycle.

Did not noticed that crash fact in the report\

Iliya Katushenock closed issue blender/blender#127129 2024-09-04 06:52:36 +02:00
Mesh to Volume node inconsistent with concave corners
Iliya Katushenock commented on issue blender/blender#127129 2024-09-04 06:52:32 +02:00
Mesh to Volume node inconsistent with concave corners

Thanks for the report, but the issue reported here is a request for modified/improved behavior and not a bug in current behavior. Closing as this bug tracker is only for bugs and errors.

For…

Iliya Katushenock commented on pull request blender/blender#125592 2024-09-03 22:32:54 +02:00
WIP: BLI: Boolean polygon clipping using the Greiner Hormann algorithm.

Important part of the readability is the source data and destination, just do() does not imply anything and only hide the actual actions.

Iliya Katushenock commented on pull request blender/blender#125592 2024-09-03 22:27:25 +02:00
WIP: BLI: Boolean polygon clipping using the Greiner Hormann algorithm.

I am about to replace all bottom if-staments hall.

Iliya Katushenock commented on pull request blender/blender#125592 2024-09-03 22:24:11 +02:00
WIP: BLI: Boolean polygon clipping using the Greiner Hormann algorithm.

I think you did misunderstand what DefaultMixer is.

Iliya Katushenock commented on pull request blender/blender#125592 2024-09-03 22:22:52 +02:00
WIP: BLI: Boolean polygon clipping using the Greiner Hormann algorithm.

Still do not see any reason to check input/decide somethoug about cases. This looks like valid output for valid input and invalid output for invalid input.

Iliya Katushenock commented on pull request blender/blender#125592 2024-09-03 21:59:38 +02:00
WIP: BLI: Boolean polygon clipping using the Greiner Hormann algorithm.

But why zero points num need to be classified as valid?/

Iliya Katushenock commented on pull request blender/blender#125592 2024-09-03 21:50:50 +02:00
WIP: BLI: Boolean polygon clipping using the Greiner Hormann algorithm.

Input: curve Result:

  1. All: Curve Keeped as is
  2. Nothing: Curve is deleted
  3. FirstAndOverNext: First point - part of the first curve segment is keeped, next segment is inside and…
Iliya Katushenock commented on pull request blender/blender#125592 2024-09-03 21:41:53 +02:00
WIP: BLI: Boolean polygon clipping using the Greiner Hormann algorithm.

This is not about just inline but rather do not use such code style when you just type some word and nothing else. Something like MutableSpan<> dst_poly = this->new_polygon(size); would be much…

Iliya Katushenock closed issue blender/blender#127122 2024-09-03 21:16:45 +02:00
Anim player is wrong
Iliya Katushenock commented on issue blender/blender#127122 2024-09-03 21:16:41 +02:00
Anim player is wrong

This report does not contain all the requested information, which is required for us to investigate the issue.

Please submit a new report and carefully follow the instructions. Be sure to…

Iliya Katushenock commented on issue blender/blender#127104 2024-09-03 21:00:58 +02:00
"Affect Transform" does not work when a constraint is using Custom Space

[Please describe the exact steps needed to reproduce the issue] [Based on the default startup or an attached .blend file (as simple as possible)] Example file would alos help/

Iliya Katushenock commented on pull request blender/blender#127002 2024-09-03 20:52:46 +02:00
Sculpt: Restructure PBVH drawing to avoid overhead

Seems like good candidate for foreach_index_optimized?/

Iliya Katushenock commented on pull request blender/blender#125592 2024-09-03 19:37:46 +02:00
WIP: BLI: Boolean polygon clipping using the Greiner Hormann algorithm.

I beleve this is unneccessery to do that at BLI level.

Iliya Katushenock commented on pull request blender/blender#125592 2024-09-03 19:37:45 +02:00
WIP: BLI: Boolean polygon clipping using the Greiner Hormann algorithm.

The same as with result_None, just unnecessary copy.

Iliya Katushenock commented on pull request blender/blender#125592 2024-09-03 19:37:44 +02:00
WIP: BLI: Boolean polygon clipping using the Greiner Hormann algorithm.

return {};, idk why such function is necessary.