Iliya Katushenock mod_moder
  • Russian
  • Just student

  • Joined on 2019-01-20
Iliya Katushenock commented on pull request blender/blender#110769 2024-08-29 17:57:41 +02:00
Function Node: Hash Value

Coud be data_type as in all other nodes?

Iliya Katushenock commented on pull request blender/blender#110769 2024-08-29 17:57:40 +02:00
Function Node: Hash Value

Swap get_multi_function and node_gather_link_searches things, just to less mix them/

Iliya Katushenock commented on pull request blender/blender#126888 2024-08-29 17:54:56 +02:00
BLI: optimize constructing IndexMask from bits and bools

Did not noticed difference with _mm_load_si128\

Iliya Katushenock deleted branch index_mask_possible_skip_writing from mod_moder/blender 2024-08-29 06:39:48 +02:00
Iliya Katushenock closed pull request blender/blender#126762 2024-08-29 06:39:41 +02:00
BLI: IndexMask: Allow possible optimization
Iliya Katushenock commented on pull request blender/blender#126762 2024-08-29 06:39:38 +02:00
BLI: IndexMask: Allow possible optimization

#126888

Iliya Katushenock commented on pull request blender/blender#126888 2024-08-28 21:50:13 +02:00
BLI: optimize constructing IndexMask from bits and bools

I had some trouble while implementing a Potrace curves converter since i stated from the generation of the bits image from the bool field (even had to deep into swar and multiplication method to shift 8 books to char). This makes things much more easier! Even IndexMask is not really necessary, at least before this will be a field kind of\

Iliya Katushenock commented on pull request blender/blender#126888 2024-08-28 21:50:12 +02:00
BLI: optimize constructing IndexMask from bits and bools

Wonder if this can have more integration with offset indices as just a chessboard for them\

Iliya Katushenock commented on pull request blender/blender#126888 2024-08-28 21:50:11 +02:00
BLI: optimize constructing IndexMask from bits and bools

Wonder if popcount check for all-range-or-all-not will be faster in benchmarks\

Iliya Katushenock commented on pull request blender/blender#126888 2024-08-28 21:50:10 +02:00
BLI: optimize constructing IndexMask from bits and bools

Note: the SWAP can be scaled even for 128 and 256 and 512 bits, we only need register, mask, shift and add operations. SWAR popcount is log2 asymptotic algorithm\

Iliya Katushenock commented on pull request blender/blender#126888 2024-08-28 21:50:08 +02:00
BLI: optimize constructing IndexMask from bits and bools

Can be constexpr/

Iliya Katushenock commented on pull request blender/blender#126888 2024-08-28 21:50:07 +02:00
BLI: optimize constructing IndexMask from bits and bools

In the most worst case where number of the gaps is equal to the number of the set bits and distribution is perfectly uniform (1, 0, 1, 0, 1, 0, ...) number of the ranges equal to the number of the set bits and maximum that is possible (half of the possible set bits). So this seems like x2 oversized buffer.

Iliya Katushenock commented on pull request blender/blender#126888 2024-08-28 21:50:06 +02:00
BLI: optimize constructing IndexMask from bits and bools

Does we have some check that bool_ is 16-bytes aligned? Think here is have to be additional prefix handling.

Iliya Katushenock commented on issue blender/blender#126864 2024-08-28 07:32:19 +02:00
blender crashed when pack a 16384x16384 float image

I think few years ago there was simular report\

Iliya Katushenock closed issue blender/blender#126853 2024-08-28 06:44:55 +02:00
Merge doubles is breaking uv stored at face corners
Iliya Katushenock commented on issue blender/blender#126853 2024-08-28 06:44:51 +02:00
Merge doubles is breaking uv stored at face corners

static void customdata_weld(
const CustomData *source, CustomData *dest, const int *src_indices, int count, int dest_index)
{
if (count == 1) {
CustomData_copy_data(source, dest, src_indices[0], dest_index, 1);
return;
}
CustomData_interp(source, dest, (const int *)src_indices, nullptr, nullptr, count, dest_index);

https://projects.blender.org

Iliya Katushenock closed issue blender/blender#126853 2024-08-27 20:43:42 +02:00
Merge doubles is breaking uv stored at face corners
Iliya Katushenock commented on issue blender/blender#126853 2024-08-27 20:43:38 +02:00
Merge doubles is breaking uv stored at face corners

I do not know what is your expectations, attached file looks different from the report and i do not see any bug in the file, so i'll close this as not a bug.

Please submit a new report and…

Iliya Katushenock closed issue blender/blender#126848 2024-08-27 18:51:07 +02:00
Unexpected Result in Fill Curve
Iliya Katushenock commented on issue blender/blender#126848 2024-08-27 18:01:02 +02:00
Unexpected Result in Fill Curve

THe fact that face is there or not is defined by combination of tracing and order of the points in curve, so the fact of different result for different positions does not seems like a bug.