Bastien Montagne mont29
4 Followers · 0 Following
  • Amsterdam, The Netherlands

  • Blender developer, mainly focused on 'Core' module.

  • Joined on 2010-10-07
Overview Repositories
8
 Projects Public Activity Starred Repositories
Bastien Montagne pushed to tmp-brush-assets at mont29/blender 2023-02-16 18:43:46 +01:00
80ffca29e7 Brush Assets: Add initial support for the new 'brush asset' usage.
c403f8a7b0 Add low-level support code in BKE link/append area for 'brush assets'.
Compare 2 commits »
Bastien Montagne approved blender/blender#104828 2023-02-16 18:07:39 +01:00
Fix #104785: Quick fur keeps asset status of appended node groups

Thanks, LGTM now.

Bastien Montagne suggested changes for blender/blender#104828 2023-02-16 17:04:31 +01:00
Fix #104785: Quick fur keeps asset status of appended node groups

Patch LGTM, but the name of the commit is not valid, it should not hide a change to a generic API behind a issue fix.

Bastien Montagne approved blender/blender#104815 2023-02-16 16:03:15 +01:00
Fix #104810: Appending a camera does not pull in background movie clip

LGTM now indeed. :)

Bastien Montagne commented on pull request blender/blender#104814 2023-02-16 14:06:28 +01:00
Fix #98583: Appending a particle system pulls in an unused collection

If we wanted that behavior, indeed non-currently-used pointers should be cleared when the source is switched. That way info would not be stored in file etc.

But as long as the reference to the…

Bastien Montagne suggested changes for blender/blender#104815 2023-02-16 12:46:26 +01:00
Fix #104810: Appending a camera does not pull in background movie clip

The logic in this code is also wrong, these two pointers should be expanded, regardless of the source setting.

Bastien Montagne closed pull request blender/blender#104814 2023-02-16 12:45:12 +01:00
Fix #98583: Appending a particle system pulls in an unused collection
Bastien Montagne commented on pull request blender/blender#104814 2023-02-16 12:45:11 +01:00
Fix #98583: Appending a particle system pulls in an unused collection

I would not accept this change at all. If you follow that logic, then you can also not link the force collection if its not needed etc.

Bastien Montagne closed issue blender/blender#98583 2023-02-16 12:44:58 +01:00
Appending a particle system pulls in an unused collection
Bastien Montagne commented on issue blender/blender#98583 2023-02-16 12:44:56 +01:00
Appending a particle system pulls in an unused collection

This is expected behavior, no bug here.

Starting to implicitly filter out what data we import based on what is currently exposed to the user is a hard no-go. If you do not want your collection…

Bastien Montagne commented on pull request blender/blender#104459 2023-02-16 11:24:33 +01:00
Refactor: in USD importer extract read_mesh params into a struct

@blender-bot build

035fa023cd Added const back onto parameters in function definitions. Fixed comment for USDMeshReadParams.
3632315b77 Add new create_mesh_read_params function. Remove unnecessary const.
7f27ea6fd7 Added documentation to USDMeshReadParams. Removed unnecessary pointer usage.
79293e3465 USD Importer refactor: Extracting read_mesh params into a struct
c39b81d832 UI: Improvement to screen_find_area_xy
Compare 519 commits »
Bastien Montagne approved blender/blender#104459 2023-02-16 11:22:11 +01:00
Refactor: in USD importer extract read_mesh params into a struct

LGTM too.

Bastien Montagne commented on pull request blender/blender#104553 2023-02-16 11:04:59 +01:00
Use hash for Collection.gobject lookup, speedup object linking

This call can be removed (see comment in collection_gobject_hash_ensure).

Bastien Montagne suggested changes for blender/blender#104553 2023-02-16 11:04:59 +01:00
Use hash for Collection.gobject lookup, speedup object linking

Found some more possible tweaks and improvements...

Bastien Montagne commented on pull request blender/blender#104553 2023-02-16 11:04:58 +01:00
Use hash for Collection.gobject lookup, speedup object linking

Would say this should also use collection_gobject_hash_ensure? While the overhead of initialization may be significant, this is often called in a collection manipulation context, where other calls (like object adding) will ensure the hash anyway... And then code is simpler, call to BLI_ASSERT_COLLECION_GOBJECT_HASH_IS_VALID can be removed, etc.

Bastien Montagne commented on pull request blender/blender#104553 2023-02-16 11:04:58 +01:00
Use hash for Collection.gobject lookup, speedup object linking

You can save a lookup here by using BLI_ghash_ensure_p instead... Since you know you'll always end up with a valid cob for the given ob key in that function.

Bastien Montagne commented on pull request blender/blender#104553 2023-02-16 11:04:58 +01:00
Use hash for Collection.gobject lookup, speedup object linking

Not sure why we still have this actually?

Bastien Montagne commented on pull request blender/blender#104553 2023-02-16 11:04:58 +01:00
Use hash for Collection.gobject lookup, speedup object linking

Should also call BLI_ASSERT_COLLECION_GOBJECT_HASH_IS_VALID here.

Bastien Montagne commented on pull request blender/blender#104553 2023-02-16 11:04:58 +01:00
Use hash for Collection.gobject lookup, speedup object linking

This call can be removed (see comment in collection_gobject_hash_ensure).