Only checked the parts in GHOST currently. I find the API documentation scattering between GHOST_C-api.h
, GHOST_IContext.h
, and others, fairly confusing...
Bah forgot to re-enable vulkan before trying again...
Yes tests are working and passing now with this command, not sure why running it with something like `CTest -R "Vulkan" does not work though...
std::tmpnam
for creating a temporary file.
Although not strictly mandatory, it's good practice to add a comment reminder of the entering condition when the closing #endif
is a bit far away in code: #endif /* !defined (__APPLE__) */
Besides the two style-related comments below, this LGTM now. No need for another review from me once these are addressed.
These (and the ones below inside the `` block) should be indented (# if defined(WIN32)
). clangformat should handle that for you if configured in your IDE... Otherwise please run make format
before committing. ;)
Patch builds for me with WITH_VULKAN_BACKEND
enabled.
How do we run these tests? I enabled both draw and render Opengl options in CMake, but these do not seem to run any of the GPU ones…