- Amsterdam, The Netherlands
-
Blender developer, mainly focused on 'Core' module.
- Joined on
2010-10-07 -
-
Although not strictly mandatory, it's good practice to add a comment reminder of the entering condition when the closing #endif is a bit far away in code: #endif /* !defined (__APPLE__) */
Besides the two style-related comments below, this LGTM now. No need for another review from me once these are addressed.
These (and the ones below inside the `` block) should be indented (# if defined(WIN32)). clangformat should handle that for you if configured in your IDE... Otherwise please run make format before committing. ;)
Patch builds for me with WITH_VULKAN_BACKEND enabled.
How do we run these tests? I enabled both draw and render Opengl options in CMake, but these do not seem to run any of the GPU ones…
Yes, exactly as e.g. BLI_file_attributes is handled.
Note that other functions, like BLI_expand_tilde, are fully defined in the .mm file for OSX, and not defined at all in the C file for this platform.
Since these new functions also share very…
This is indeed expected behavior, the Action ID is used by the Object, not using the Object, so it is unaffected by the remapping of usages from old object to new one.