- Amsterdam, The Netherlands
-
Blender developer, mainly focused on 'Core' module.
- Joined on
2010-10-07 -
-
@blender-bot build
Updated comments.
PR is fairly big so hard to be 100% sure nothing is wrong, but could not spot any issue in the code.
Will add a quick reference to this BKE_id_new in BKE_image comments
In this case, it actually matters, as a specified nullptr Library value does not have the same meaning as a std::nullopt. This is related to underlying ID management API (see e.g. documentation…
Code looks reasonable to me, and has been tested by some users (see #129267).
LGTM, also tested with ASAN debug builds and everything seems fine.
Would need more information about the benefits of the new implementation, and how different are the results it produces compared to the existing code.
If the results are different, then indeed…
Quickly talked with @Sergey regarding merging this in 4.3, we agreed that it is not necessary and can just go in main (mostly because official python version for Blender follows the VFX…
Even one-line if conditions should use braces {/}.