Nathan Vegdahl nathanvegdahl
3 Followers · 0 Following
  • Amsterdam, Netherlands
  • https://cessen.com

  • Animator, rigger, and software developer. Currently working at the Blender Institute as a developer on Blender's animation system.

    Been using Blender since 1998, and worked on Big Buck Bunny and Sintel (two of Blender's open movie projects).

  • Joined on 2003-03-21
Overview Repositories
8
 Projects Public Activity Starred Repositories
Nathan Vegdahl commented on pull request blender/blender#129002 2024-10-14 20:35:02 +02:00
Fix: handle embedded IDs when upgrading to slotted actions

@blender-bot build

d2f4fcfb59 Set the slot name prefix
7b82ffbdb6 Merge branch 'main' into fix_action_upgrade_for_embedded_ids
975b5f4533 Anim: invert Action editor 'Show All Slots' filter flag meaning
bb310831b8 Anim: don't depend on space data pointer when unassigning Action
ab1cd6f223 Anim: also copy tmp_slot_handle and tmp_slot_name on liboverride apply
5cdb950bef Anim: Fix pose library flipping with slotted Actions
Compare 23 commits »
Nathan Vegdahl commented on pull request blender/blender#129002 2024-10-14 20:00:00 +02:00
Fix: handle embedded IDs when upgrading to slotted actions

Huh. I've tried kicking off the build bot twice now, and both have been met by complete silence. Not sure what's going on.

Nathan Vegdahl commented on pull request blender/blender#129002 2024-10-14 19:58:02 +02:00
Fix: handle embedded IDs when upgrading to slotted actions

@blender-bot build

Nathan Vegdahl approved blender/blender#128889 2024-10-14 19:57:36 +02:00
Anim: Remove 'Slotted Actions' experimental flag

Didn't catch anything that looks wrong, so I think as soon as #129002 lands we can land this.

Nathan Vegdahl commented on pull request blender/blender#128889 2024-10-14 19:38:13 +02:00
Anim: Remove 'Slotted Actions' experimental flag

This PR also contains #128892, which should definitely land first. After that I'll rebase this PR to clean it up.

Based on what you said in person earlier and looking at the two PRs, I assume…

Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-10-14 18:54:23 +02:00
8d1abe1950 Update reports/2024.md
Nathan Vegdahl commented on pull request blender/blender#129002 2024-10-14 18:46:36 +02:00
Fix: handle embedded IDs when upgrading to slotted actions

@blender-bot build

ed9036517c Address review comments
Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-10-14 18:33:49 +02:00
3f11fa9a26 Update reports/2024.md
Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-10-14 18:31:46 +02:00
de1f1e9440 Update reports/2024.md
Nathan Vegdahl approved blender/blender#129011 2024-10-14 18:30:53 +02:00
Anim: invert Action editor 'Show All Slots' filter flag meaning
Nathan Vegdahl approved blender/blender#128992 2024-10-14 18:25:05 +02:00
Anim: Fix pose library flipping with slotted Actions

Just one note that you can take or leave (it's more of a stylistic preference thing).

Nathan Vegdahl commented on pull request blender/blender#128992 2024-10-14 18:25:04 +02:00
Anim: Fix pose library flipping with slotted Actions

Rather than creating the fcurves temporary, you can just pass animrig::legacy::fcurves_first_slot(act) directly as the argument to BKE_fcurve_pathcache_create(). C++ doesn't destruct temporaries in arguments until the function has returned.

3f653fde13 Loop over embedded IDs properly
Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-10-14 15:33:56 +02:00
04ccad5445 Update reports/2024.md
Nathan Vegdahl commented on pull request blender/blender#129002 2024-10-14 15:33:06 +02:00
Fix: handle embedded IDs when upgrading to slotted actions

@blender-bot build

Nathan Vegdahl commented on pull request blender/blender#129002 2024-10-14 15:32:58 +02:00
Fix: handle embedded IDs when upgrading to slotted actions

This was reviewed by @dr.sybren in person.

Nathan Vegdahl created pull request blender/blender#129002 2024-10-14 15:32:27 +02:00
Fix: handle embedded IDs when upgrading to slotted actions