- Amsterdam, Netherlands
- https://cessen.com
-
Animator, rigger, and software developer. Currently working at the Blender Institute as a developer on Blender's animation system.
Been using Blender since 1998, and worked on Big Buck Bunny and Sintel (two of Blender's open movie projects).
- Joined on
2003-03-21 -
-
I was thinking about this 0.5 offset more, and I wonder if we should use a different value. For example, with a 0.5 base offset, a scale of two will result in every other frame being zero. I can also imagine people setting the offset to 0.5, which would effectively cancel this out.
I don't think we should do this division by 10.
Without the possibility of NLA remapping, I don't feel like the comment clarifies anything. It's clear the NLA remapping has already been done just looking at the code. The comment was just…
Since it's only done at that one call site, rather than making a separate function I've just inlined it there. I also changed the remapping calls to ANIM_nla_tweakedit_remap() since we have an…
The contains() in MutableSpan could be implemented internally as as_span().contains() to avoid the duplication, and help ensure the methods don't accidentally diverge.
I agree with…
Gah! Thanks for catching that. In this particular instance I can also change the function this is being passed to just take an ale instead of an adt as well.