Nathan Vegdahl nathanvegdahl
3 Followers · 0 Following
  • Amsterdam, Netherlands
  • https://cessen.com

  • Animator, rigger, and software developer. Currently working at the Blender Institute as a developer on Blender's animation system.

    Been using Blender since 1998, and worked on Big Buck Bunny and Sintel (two of Blender's open movie projects).

  • Joined on 2003-03-21
Overview Repositories
8
 Projects Public Activity Starred Repositories
Nathan Vegdahl pushed to layered_action_fcurve_groups at nathanvegdahl/blender 2024-08-16 15:46:01 +02:00
5374e5e58f Yet more elaboration
Nathan Vegdahl pushed to layered_action_fcurve_groups at nathanvegdahl/blender 2024-08-16 15:43:32 +02:00
052bb7ee9e A bit more elaboration in the last comment
Nathan Vegdahl pushed to layered_action_fcurve_groups at nathanvegdahl/blender 2024-08-16 15:39:43 +02:00
276d1c6411 Add comment about the invariants of channel groups
Nathan Vegdahl pushed to layered_action_fcurve_groups at nathanvegdahl/blender 2024-08-16 15:35:21 +02:00
6cae6832b1 Remove comment that I added on a whim for myself
Nathan Vegdahl pushed to layered_action_fcurve_groups at nathanvegdahl/blender 2024-08-16 15:24:12 +02:00
92bb33dc65 Change channel_group_containing_index() to return the group index
Nathan Vegdahl pushed to layered_action_fcurve_groups at nathanvegdahl/blender 2024-08-16 15:08:51 +02:00
5c9c155a3c Remove unused ReportList * parameter from RNA function
Nathan Vegdahl pushed to layered_action_fcurve_groups at nathanvegdahl/blender 2024-08-16 15:02:30 +02:00
b6aa2082b6 Improve code docs
Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-08-16 14:28:25 +02:00
0f855aa24d Update reports/2024.md
Nathan Vegdahl suggested changes for blender/blender#126399 2024-08-16 14:27:04 +02:00
Fix #126140: Cycle aware keying not working

I think this is fine for now, yeah. I'm not sure if I agree that it really belongs in this function, but I also just generally feel that it's pretty unclear right now what's responsible for what anyway, and we'll probably want to do some refactoring at some point to sort that out. So I think this is a fine fix given the current state of the code.

Nathan Vegdahl commented on pull request blender/blender#126399 2024-08-16 14:27:03 +02:00
Fix #126140: Cycle aware keying not working

The comment here suggests that this line was here to affect the behavior of insert_vert_fcurve(), which it's now been moved into. Can you confirm whether this line has any effect anymore? Because at least at a glance, I can't see anywhere that this flag is used after this point. If we can just kill this line altogether that would be great.

Nathan Vegdahl pushed to layered_action_fcurve_groups at nathanvegdahl/blender 2024-08-16 13:06:48 +02:00
2f67db7814 Better naming + documentation
Nathan Vegdahl commented on pull request blender/blender#125774 2024-08-16 12:43:10 +02:00
Anim: add channel groups to layered actions

So it turns out it would be a bit annoying to completely remove it, since then I'd have to duplicate the calls needed to just to basic removal of an element from an array. But I did simplify it…

Nathan Vegdahl commented on pull request blender/blender#126373 2024-08-16 12:24:12 +02:00
Fix #126128: Possible to select invisible keys in the Graph Editor

Just to be extra clear: yes, please just land as-is.

I'm probably giving mixed messages by continuing to discuss things, but I'm really just continuing the discussion for how we might want to…

Nathan Vegdahl approved blender/blender#126373 2024-08-16 12:16:24 +02:00
Fix #126128: Possible to select invisible keys in the Graph Editor
Nathan Vegdahl commented on pull request blender/blender#126373 2024-08-16 12:16:14 +02:00
Fix #126128: Possible to select invisible keys in the Graph Editor

Yeah, go ahead and land it as-is. I don't think it makes sense to block PRs on relatively minor and subjective things like this.

but having a separate function allows me to go by function…

Nathan Vegdahl pushed to layered_action_fcurve_groups at nathanvegdahl/blender 2024-08-16 12:01:02 +02:00
83c99df45a Simplify channel_group_remove_raw() and make it private
Nathan Vegdahl commented on pull request blender/blender#126373 2024-08-16 10:55:18 +02:00
Fix #126128: Possible to select invisible keys in the Graph Editor

That's totally fair! Not to block landing this in any way (just for the sake of discussion), I do, however, want to make a case for more liberal use of lambdas in c++ code:

I think one of the…

Nathan Vegdahl reopened issue blender/blender#126348 2024-08-16 10:20:12 +02:00
Visual keying doesn't preserve rotations in the expected way
Nathan Vegdahl commented on issue blender/blender#126348 2024-08-16 10:20:08 +02:00
Visual keying doesn't preserve rotations in the expected way

I think we can keep this open as a known issue.

There's no way to completely solve it in a robust mathematical sense, but I suspect we could do something like find the multiple-of-360 offset…

Nathan Vegdahl commented on issue blender/blender#126348 2024-08-15 18:12:32 +02:00
Visual keying doesn't preserve rotations in the expected way

since quaternions seem to "ease in ease out" even when set to linear.

Yeah, that happens when there are large angles between the keys. If you key every 90 degrees instead, that effect is…