- Amsterdam, Netherlands
- https://cessen.com
-
Animator, rigger, and software developer. Currently working at the Blender Institute as a developer on Blender's animation system.
Been using Blender since 1998, and worked on Big Buck Bunny and Sintel (two of Blender's open movie projects).
- Joined on
2003-03-21
ANIM_nla_mapping_apply_fcurve()
to ANIM_nla_mapping_apply_if_needed_fcurve()
get_normalized_fcurve_bounds()
Basically looks good, and works in testing. Just some minor stuff that can be addressed while landing.
On first read, my brain interpreted "update their Action Slots" as "update which Action Slots they use". I think this is a little less ambiguous (although admittedly also a bit awkward):
This paragraph feels a little out of place to me now. Prior to this PR it was explaining the contrast between the two branches, but now it feels kind of out-of-the-blue. I think we only need to explain why we're not rebuilding the slot user map here, and why that's all that's needed here.