- Amsterdam, Netherlands
- https://cessen.com
-
Animator, rigger, and software developer. Currently working at the Blender Institute as a developer on Blender's animation system.
Been using Blender since 1998, and worked on Big Buck Bunny and Sintel (two of Blender's open movie projects).
- Joined on
2003-03-21 -
-
The PR is now "ready to land" from my perspective. @dr.sybren I've left a few of your comments open because they either need more discussion or I want to double-check that I've addressed them to…
Re: explaining the related data-blocks: after sleeping on it over the weekend, I think I've come around to explaining this in a bit more detail, and then we can get rid of the TODO to link it. …
This is a bit ambiguous, as it can be read as (name) + (associated type within its action).
Ah! Good catch. I think it can be fixed by just rearranging the clauses: "Within an action, a…
I don't see it being in constant flux, and thus IMO it would be fine to just explain how it works.
I agree it's unlikely to change much, if at all. The reason I left it out of scope is…
I'm unclear on what you want here: should I change this or leave it as-is? I was aware I was lying here (😆), but I felt like it was a "good" lie for the reasons you outlined.
Good point about the wrapping. I'll do that after I've addressed the rest of your comments.
Re: keeping Action capitalized, I agree and actually initially wrote it that way. I changed it to…
That's what I was intending to get across, but clearly failed, ha ha. I'll try rephrasing to make that clearer, without getting too verbose.
That's true, but I wasn't meaning to be exhaustive here, but rather give one place that this is visible to help illustrate the concept. I'll try rephrasing to make that clearer.
Code looks good (just some stylistic preference notes that you can ignore if you disagree), and it does appear to leave the functionality as-is based on some quick testing.