Nathan Vegdahl nathanvegdahl
3 Followers · 0 Following
  • Amsterdam, Netherlands
  • https://cessen.com

  • Animator, rigger, and software developer. Currently working at the Blender Institute as a developer on Blender's animation system.

    Been using Blender since 1998, and worked on Big Buck Bunny and Sintel (two of Blender's open movie projects).

  • Joined on 2003-03-21
Overview Repositories
8
 Projects Public Activity Starred Repositories
Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-06-13 10:04:59 +02:00
31147f3971 Update reports/2024.md
Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-06-13 10:04:06 +02:00
9f179fdfcc Update reports/2024.md
Nathan Vegdahl approved blender/blender#122968 2024-06-13 09:41:47 +02:00
Give timeline marker default name when created via binding to camera

Looks good to me!

Nathan Vegdahl pushed to baklava_xyz_to_rgb at nathanvegdahl/blender 2024-06-11 17:23:15 +02:00
2ea3ce2cab Merge branch 'main' into baklava_xyz_to_rgb
2eba256719 Improve docs for BKE_animsys_nla_remap_keyframe_values()
1a4f084806 Refactor: combine insert_keyframe() and insert_key_rna() into a single function
7a9b7f527e Merge branch 'blender-v4.2-release'
60190a7ea7 Cleanup: Move IDProperty enums (types, flags, etc.) to DNA_ID_enums.h
Compare 92 commits »
Nathan Vegdahl commented on pull request blender/blender#123022 2024-06-11 17:22:14 +02:00
Anim: make "XYZ to RGB" user preference work for layered actions

@dr.sybren I think I would be even less happy with that solution, personally. It seems like an unexpected place for it to be, and I suspect that would make it rather "hidden" to people not…

Nathan Vegdahl deleted branch nla_remap_docs from nathanvegdahl/blender 2024-06-11 16:55:39 +02:00
Nathan Vegdahl merged pull request blender/blender#123081 2024-06-11 16:55:35 +02:00
Improve docs for `BKE_animsys_nla_remap_keyframe_values()`
Nathan Vegdahl pushed to main at blender/blender 2024-06-11 16:55:34 +02:00
2eba256719 Improve docs for BKE_animsys_nla_remap_keyframe_values()
Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-06-11 16:44:54 +02:00
1a0bf21cfd Update reports/2024.md
Nathan Vegdahl deleted branch combine_keying_functions from nathanvegdahl/blender 2024-06-11 16:43:11 +02:00
Nathan Vegdahl merged pull request blender/blender#122053 2024-06-11 16:43:09 +02:00
Refactor: combine insert_keyframe() and insert_key_rna() into a single function
Nathan Vegdahl pushed to main at blender/blender 2024-06-11 16:43:08 +02:00
1a4f084806 Refactor: combine insert_keyframe() and insert_key_rna() into a single function
Nathan Vegdahl suggested changes for blender/blender#122968 2024-06-11 16:40:15 +02:00
Give timeline marker default name when created via binding to camera

Just a minor style nit. Otherwise looks good to me.

Nathan Vegdahl commented on pull request blender/blender#122968 2024-06-11 16:40:14 +02:00
Give timeline marker default name when created via binding to camera

Nit: use proper capitalization and punctuation in comments.

Nathan Vegdahl commented on pull request blender/blender#123081 2024-06-11 16:27:37 +02:00
Improve docs for BKE_animsys_nla_remap_keyframe_values()

@blender-bot build

Nathan Vegdahl commented on pull request blender/blender#122377 2024-06-11 16:26:53 +02:00
Fix #122372: Keyingsets not keying custom properties of type EnumProperty

Yeah, in general enum properties should be keyable unless marked otherwise (just as with other properties). So I think this was probably just an accidental omission.

That does make me wonder,…

Nathan Vegdahl commented on pull request blender/blender#122053 2024-06-11 16:14:16 +02:00
Refactor: combine insert_keyframe() and insert_key_rna() into a single function

@blender-bot build

Nathan Vegdahl pushed to combine_keying_functions at nathanvegdahl/blender 2024-06-11 16:11:42 +02:00
61184ba9b6 Make if condition more immediately readable
Nathan Vegdahl commented on pull request blender/blender#122053 2024-06-11 16:08:32 +02:00
Refactor: combine insert_keyframe() and insert_key_rna() into a single function

The operator precedence is unambiguous in C++ at least, but I agree that it would help readability a lot here, regardless.

Nathan Vegdahl commented on pull request blender/blender#122053 2024-06-11 15:43:54 +02:00
Refactor: combine insert_keyframe() and insert_key_rna() into a single function

I've now removed the output parameter descriptions, leaving that to #123081. I also renamed the elements_to_key variable to rna_values_mask, to make its relationship to rna_values more obvious.