- Amsterdam, Netherlands
- https://cessen.com
-
Animator, rigger, and software developer. Currently working at the Blender Institute as a developer on Blender's animation system.
Been using Blender since 1998, and worked on Big Buck Bunny and Sintel (two of Blender's open movie projects).
- Joined on
2003-03-21 -
-
Good call. I've made a separate PR that can be landed either before or after this one that (hopefully) improves the documentation of BKE_animsys_nla_remap_keyframe_values() in the ways needed…
BKE_animsys_nla_remap_keyframe_values()
Good point. But since the intent is to remove the redundancy in a future PR anyway, I think it's fine for now.
Will do. I also left a todo in the doc comment about it now.
Ah! Thanks for catching that. I wrote those docs when I thought AnimationEvalContext represented something more fundamental/core than it actually does.
I agree this is redundant. The reason for both to exist right now is:
- That same redundancy was already present in
insert_key_rna(), and I'm trying to keep this as close to a pure "combine…
Yeah, I'm also not happy about that. But it seemed like the least bad option under the circumstances.
Indeed, I think it's weird that the fcurve colors are a stored property that's determined…