studio/blender-studio-tools
13
32
Fork 19
Code Issues 22 Pull Requests 4 Projects Releases 1 Activity

AnimCupboard: ID Management Pie #127

Merged
Demeter Dzadik merged 11 commits from Mets/blender-studio-pipeline:AnimCupboard-relationship-viewer into main 2023-07-19 14:43:14 +02:00
Conversation 0 Commits 11 Files Changed 3 +5 -5
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 6e489eb1f6 - Show all commits

10
scripts-blender/addons/anim_cupboard/operators/id_management_pie.py
View File

@ -88,7 +88,7 @@ class RelationshipOperatorMixin:
raise NotImplementedError raise NotImplementedError
def get_label(self): def get_label(self):
return "Showing users of datablock:" return "Listing datablocks that reference this:"
def draw(self, context): def draw(self, context):
layout = self.layout layout = self.layout
@ -178,7 +178,7 @@ class OUTLINER_OT_list_dependencies_of_datablock(
bl_label = "List Datablock Dependencies" bl_label = "List Datablock Dependencies"
def get_label(self): def get_label(self):
return "Showing dependencies of datablock:" return "Listing datablocks that are referenced by this:"
def get_datablocks_to_display(self, datablock: bpy.types.ID) -> List[bpy.types.ID]: def get_datablocks_to_display(self, datablock: bpy.types.ID) -> List[bpy.types.ID]:
dependencies = id_map_utils.get_id_reference_map().get(datablock) dependencies = id_map_utils.get_id_reference_map().get(datablock)
@ -281,14 +281,14 @@ class OUTLINER_OT_remap_users(bpy.types.Operator):
id = self.get_source_id() id = self.get_source_id()
id_icon = get_datablock_icon(id) id_icon = get_datablock_icon(id)
split = row.split() split = row.split()
split.row().label(text="Remap Users of ID:") split.row().label(text="Anything that was referencing this:")
row = split.row() row = split.row()
row.prop(self, 'id_name_source', text="", icon=id_icon) row.prop(self, 'id_name_source', text="", icon=id_icon)
row.enabled = False row.enabled = False
layout.separator() layout.separator()
col = layout.column() col = layout.column()
col.label(text="Remap users to: ") col.label(text="Will now reference this instead: ")
if len(scene.remap_target_libraries) > 1: if len(scene.remap_target_libraries) > 1:
Nick Alberelli commented 2023-07-18 18:15:20 +02:00
Outdated
Review
Copy Link

This loop is looking for a VIEW_3D but the report says it is checking if an outliner is present. Assuming the outliner is what you are looking for wouldn't it be more explicit to do...

for area in context.screen.areas:
    if area.type == 'OUTLINER':
        break
else:
    self.report(
        {'ERROR'}, "Error: This operation requires an Outliner to be present."
    )
    return {'CANCELLED'}
This loop is looking for a `VIEW_3D` but the report says it is checking if an outliner is present. Assuming the outliner is what you are looking for wouldn't it be more explicit to do... ```python for area in context.screen.areas: if area.type == 'OUTLINER': break else: self.report( {'ERROR'}, "Error: This operation requires an Outliner to be present." ) return {'CANCELLED'} ```
col.prop_search( col.prop_search(
self, self,
@ -302,7 +302,7 @@ class OUTLINER_OT_remap_users(bpy.types.Operator):
'id_name_target', 'id_name_target',
scene, scene,
'remap_targets', 'remap_targets',
text="Remap To", text="Datablock",
icon=id_icon, icon=id_icon,
) )