From 653d8c908388460f6a3392368dad259d5a851c94 Mon Sep 17 00:00:00 2001
From: Julien Kaspar <julienkaspar@noreply.localhost>
Date: Fri, 16 Feb 2024 15:52:08 +0100
Subject: [PATCH] Update docs/gentoo/user/installing-software.md

Made some comments for feedback.
Also made some edits for minor formatting, rephrasing and missing information.
---
 docs/gentoo/user/installing-software.md       | 32 +++++++++++++++----
 .../addons/lighting_overrider/json_io.py      | 10 ++++--
 2 files changed, 32 insertions(+), 10 deletions(-)

diff --git a/docs/gentoo/user/installing-software.md b/docs/gentoo/user/installing-software.md
index e2995a3c..3d160efd 100644
--- a/docs/gentoo/user/installing-software.md
+++ b/docs/gentoo/user/installing-software.md
@@ -6,24 +6,39 @@ outline: deep
 
 There are two ways to install and uninstall software.
 
+<!-- Feedback from Julien
+First paragraph should give a quick overview of "merge" vs "Discover". 
+One sentence each, with quick understanding of pros/cons.
+-->
+
 ## Emerge
 
-emerge is the default package manager, use emerge to install, update, and generally maintain software packages on Gentoo. emerge should always be your first option when searching for software. To learn more: https://wiki.gentoo.org/wiki/Emerge
+**emerge** is the default package manager. Use **emerge** to install, update, and generally maintain software packages on Gentoo. **emerge** should always be your first option when searching for software. For in-depth information: https://wiki.gentoo.org/wiki/Emerge
 
 ### Open Terminal and Become Root
 
 ![Open Terminal from Taskbar](/media/user-guide/workstations/gentoo_workstation_open_terminal.mp4)
 
-1.  From the Task Bar select the “KDE Logo” to open the Start Menu, and type “Terminal” in the search bar
-2.  Become root via `su`
+<!-- Feedback from Julien
+This video seems redundant. 
+Either visually show all steps of installing and removing software or remove the video.
+-->
 
+1.  From the Task Bar select the “KDE Logo” to open the Start Menu, and type “Terminal” in the search bar
+2.  Type in `su` and press Enter to become **root**.
+3.  Enter the password and press Enter
+
+The line text turn red to indicate that you are now **root**.
+You must be **root** to make changes via **emerge**.
 
 ### Search & Install software via emerge
 
-**emerge** provides commands to install packages onto your system including any dependencies. You must be **root** to make changes via **emerge**. _In this example package name is **spotify**._
+**emerge** provides commands to install packages onto your system including any dependencies.  _In this example package name is **spotify**._
 
 1.  [Open Terminal and Become Root](/gentoo/user/installing-software.md#open-terminal-and-become-root)
-2.  Find avaliable packages using the `eix` for example: `eix spotify`
+2.  Find avaliable packages using the `eix` command in the terminal. For example: `eix spotify`
+
+The search results will appear in the terminal like this:
 
 ```bash
 * gnome-extra/gnome-integration-spotify
@@ -44,8 +59,11 @@ emerge is the default package manager, use emerge to install, update, and genera
 Found 3 matches
 ```
 
-3.  Install a package via emerge: `emerge spotify`
-4.  (Optionally) install a specific package version via `emerge ={package-name}-{version}` _Example:_ `emerge =spotify-1.2.8`
+3.  Install the latest or a specific version:
+     1.   Install a package via emerge: `emerge spotify`
+     2.  (Optionally) install a specific package version via `emerge ={package-name}-{version}` _Example:_ `emerge =spotify-1.2.8`
+
+The terminal will show the install process and confirm once it's done:
 
 ```bash
 Calculating dependencies... done!
diff --git a/scripts-blender/addons/lighting_overrider/json_io.py b/scripts-blender/addons/lighting_overrider/json_io.py
index 4ab27d62..8f35639a 100644
--- a/scripts-blender/addons/lighting_overrider/json_io.py
+++ b/scripts-blender/addons/lighting_overrider/json_io.py
@@ -49,8 +49,10 @@ class LOR_OT_read_settings(bpy.types.Operator):
             override = context.copy()
             area_type = override['area'].type
             override['area'].type = 'TEXT_EDITOR'
+            override['region'] = override['area'].regions[0]
             override['edit_text'] = text
-            bpy.ops.text.reload(override)
+            with context.temp_override(**override):
+               bpy.ops.text.reload()
             override['area'].type = area_type
         
         data = read_data_from_json(text)
@@ -88,8 +90,10 @@ class LOR_OT_write_settings(bpy.types.Operator):
             override = context.copy()
             area_type = override['area'].type
             override['area'].type = 'TEXT_EDITOR'
+            override['region'] = override['area'].regions[0]
             override['edit_text'] = text
-            bpy.ops.text.save(override)
+            with context.temp_override(**override):
+                bpy.ops.text.save()
             override['area'].type = area_type
         settings.is_dirty = False
         
@@ -151,7 +155,7 @@ def write_data_to_json(text: bpy.types.Text, data: dict, partial=None):
     return
 
 def read_data_from_json(text: bpy.types.Text):
-    return json.loads(text.as_string())
+    return json.loads(text.as_string()) if text.as_string() else json.loads('{}')
 
 
 classes = (
-- 
2.30.2