studio/blender-studio-tools
13
32
Fork 19
Code Issues 22 Pull Requests 4 Projects Releases 1 Activity

Convert Blender-Purge to a more generic Blender-Crawl Tool #42

Merged
Nick Alberelli merged 34 commits from feature/blender-crawl into main 2023-05-17 15:38:47 +02:00
Conversation 0 Commits 34 Files Changed 19 +3 -8
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit ba0e35614d - Show all commits

11
scripts/blender-crawl/blender_crawl/__main__.py
View File

@ -80,13 +80,8 @@ def exception_handler(func):
f"\n# Error: {error}"
"\n# Program will be cancelled."
)
cancel_program
return func_wrapper
def cancel_program() -> None:
print("# Exiting blender-crawl")
sys.exit(0)
return func_wrapper
def find_default_blender():
output = subprocess.check_output(['whereis', 'blender'])
Sebastian Parborg commented 2023-05-11 12:10:59 +02:00
Outdated
Review
Copy Link

I don't think there is much of a reason to have this function?

When I look at the code, it seems like all calls to this could be replaced with sys.exit(0) without any loss.

I don't think there is much of a reason to have this function? When I look at the code, it seems like all calls to this could be replaced with `sys.exit(0)` without any loss.
Nick Alberelli commented 2023-05-11 19:06:23 +02:00
Outdated
Review
Copy Link

We handled this together on the phone! Issue has been resolved. 81083cdb01

We handled this together on the phone! Issue has been resolved. https://projects.blender.org/studio/blender-studio-pipeline/commit/81083cdb01fa4d61229f28b38df5f6fbc6096288
@ -307,7 +302,7 @@ def run_blender_crawl(args: argparse.Namespace) -> int:
# Can only happen on folder here.
if not files:
print("# Found no .blend files to crawl")
cancel_program()
sys.exit(0)
# Sort.
files.sort(key=lambda f: f.name)
@ -315,7 +310,7 @@ def run_blender_crawl(args: argparse.Namespace) -> int:
# Prompt confirm.
if not yes:
if not prompt_confirm(files):
cancel_program()
sys.exit(0)
# crawl each file two times.