studio/blender-studio-tools
13
32
Fork 19
Code Issues 22 Pull Requests 4 Projects Releases 1 Activity

Blender Kitsu: Use Background Thread for Kitsu Login #79

Merged
Nick Alberelli merged 6 commits from fix/blender-kitsu-bg-threading into main 2023-06-16 17:44:21 +02:00
Conversation 3 Commits 6 Files Changed 1 +22 -10
Nick Alberelli commented 2023-06-14 23:07:12 +02:00
Member
Copy Link

Closes: studio/blender-studio-pipeline#18

What's Changed

  • Use BG Thread when loggin in
  • BG Thread is restarted if user restarts login process
Closes: https://projects.blender.org/studio/blender-studio-pipeline/issues/18 ### What's Changed - Use BG Thread when loggin in - BG Thread is restarted if user restarts login process
Nick Alberelli added 1 commit 2023-06-14 23:07:14 +02:00
Nick Alberelli requested review from Sebastian Parborg 2023-06-14 23:09:23 +02:00
Sebastian Parborg commented 2023-06-15 14:57:39 +02:00
Member
Copy Link

How does this work?
I thought that you needed to manually start the thread and also check if there were any current threads running before starting a new one.

There doesn't seem to be any logic for any of that. So even if the thread gets started automatically, it seems like there can be race conditions now as nothing is preventing it from running multiple threads with the same task at the same time.

How does this work? I thought that you needed to manually start the thread and also check if there were any current threads running before starting a new one. There doesn't seem to be any logic for any of that. So even if the thread gets started automatically, it seems like there can be race conditions now as nothing is preventing it from running multiple threads with the same task at the same time.
Nick Alberelli changed title from Blender Kitsu: Use Background Thread for Kitsu Login to WIP: Blender Kitsu: Use Background Thread for Kitsu Login 2023-06-15 17:05:48 +02:00
Nick Alberelli commented 2023-06-15 17:06:48 +02:00
Author
Member
Copy Link

TODO

  • Create a global variable for the thread
  • Check thread if its already running before starting a new one
  • SO when we get into the function is the thread currently running do nothing
## TODO - Create a global variable for the thread - Check thread if its already running before starting a new one - SO when we get into the function is the thread currently running do nothing
Nick Alberelli added 1 commit 2023-06-16 04:26:55 +02:00
Nick Alberelli force-pushed fix/blender-kitsu-bg-threading from 025bb735ce to 8a037fd216 2023-06-16 04:48:11 +02:00 Compare
Nick Alberelli added 1 commit 2023-06-16 04:50:42 +02:00
Nick Alberelli commented 2023-06-16 04:56:11 +02:00
Author
Member
Copy Link

@ZedDB could you take a look at this now, I have added some logic that checks if a thread is running. I decided instead of doing nothing to kill the thread and restart to provide a better experience for users who are trying multiple times to login with incorrect creds, let me know what u think :)

@ZedDB could you take a look at this now, I have added some logic that checks if a thread is running. I decided instead of doing nothing to kill the thread and restart to provide a better experience for users who are trying multiple times to login with incorrect creds, let me know what u think :)
Nick Alberelli force-pushed fix/blender-kitsu-bg-threading from bf568b2d4e to ee7da5d857 2023-06-16 05:10:14 +02:00 Compare
Nick Alberelli added 1 commit 2023-06-16 05:16:56 +02:00
Nick Alberelli changed title from WIP: Blender Kitsu: Use Background Thread for Kitsu Login to Blender Kitsu: Use Background Thread for Kitsu Login 2023-06-16 05:17:44 +02:00
Nick Alberelli force-pushed fix/blender-kitsu-bg-threading from a286983238 to ed2c588b52 2023-06-16 16:38:27 +02:00 Compare
Nick Alberelli merged commit 32b7fc0c49 into main 2023-06-16 17:44:21 +02:00
Nick Alberelli deleted branch fix/blender-kitsu-bg-threading 2023-06-16 17:44:21 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Sebastian Parborg
Labels
Clear labels   
Kind
Breaking
Breaking change that won't be backward compatible

  
Kind
Bug
Something is not working

  
Kind: Community

Issues opened by members of the community / outside the studio

  
Kind
Documentation
Documentation changes

  
Kind
Easy
Simple to complete

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
Proposal
A proposal or idea that requires feedback

  
Kind
Security
This is security issue

  
Kind
Studio Request
Requested by a user at the Blender-Studio

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind
Breaking
Kind
Bug
Kind: Community
Kind
Documentation
Kind
Easy
Kind
Enhancement
Kind
Feature
Kind
Proposal
Kind
Security
Kind
Studio Request
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/blender-studio-tools#79
No description provided.
Delete Branch "fix/blender-kitsu-bg-threading"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?