Incorrect frame range formatting when crafting blender's cmd #104245

Closed
opened 2023-08-23 10:46:20 +02:00 by Juan Ignacio Gil-Hutton · 1 comment

System Information
Operating System(s):
Windows 10
Blender 3.6

Flamenco Version
Is Broken: 3.2
Worked OK: Not tested on previous versions

Short description of error

We've found an error in the way Flamenco parses the frames field in Blender's Flamenco addon.
If we submit a render job with the following Frames kind of value in blender's addon: 0-12,34-56,78-90 and Chunk Size field greater than, at least one of the individual ranges in the Frames field, i.e. 20, (greater than 12-0=12 and greater than 90-78=12):

rendersettings.png

the cli argument passed to blender has a dash as separator, instead of a colon:

thumb-Error.png

This issue also causes flamenco to take the task as completed, even though the blender process is logging an error:

taskstatuses.png

The latter causes cascading errors if we have a task expecting the render tasks to be completed successfully (i.e. preview-video task)

**System Information** Operating System(s): Windows 10 Blender 3.6 **Flamenco Version** Is Broken: 3.2 Worked OK: Not tested on previous versions **Short description of error** We've found an error in the way Flamenco parses the frames field in Blender's Flamenco addon. If we submit a render job with the following `Frames ` kind of value in blender's addon: `0-12,34-56,78-90` and `Chunk Size` field greater than, at least one of the individual ranges in the Frames field, i.e. `20`, (greater than 12-0=12 and greater than 90-78=12): ![rendersettings.png](/attachments/dfde382f-fa09-45c3-88d2-0fbbc090f4a3) the cli argument passed to blender has a dash as separator, instead of a colon: ![thumb-Error.png](/attachments/b02b1dd2-0379-48d3-9a25-395dead3b3ae) This issue also causes flamenco to take the task as `completed`, even though the blender process is logging an error: ![taskstatuses.png](/attachments/442b48c9-abd4-47b8-8813-bfe105b96a30) The latter causes cascading errors if we have a task expecting the render tasks to be completed successfully (i.e. preview-video task)

Thanks for the detailed report, it made it trivial to reproduce & fix :)

Thanks for the detailed report, it made it trivial to reproduce & fix :)
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/flamenco#104245
No description provided.