studio/flamenco
studio
/
flamenco
12
27
Fork 32
Code Issues 60 Pull Requests 7 Releases Wiki Activity

Make runtime paths configurable at link time #104200

Manually merged
Sybren A. Stüvel merged 1 commits from ZedDB/flamenco:config into main 2023-04-04 15:41:41 +02:00
Conversation 4 Commits 1 Files Changed 4 +20 -5
Sebastian Parborg commented 2023-03-21 16:06:35 +01:00
Member
Copy Link

I know there were some notes you had on the new comments, but I'll post the unchanged commit here so I can do all changes in one go.

I know there were some notes you had on the new comments, but I'll post the unchanged commit here so I can do all changes in one go.
Sebastian Parborg added 1 commit 2023-03-21 16:06:37 +01:00
Sybren A. Stüvel requested changes 2023-03-21 16:15:05 +01:00
Sybren A. Stüvel left a comment
Owner
Copy Link

Nice patch, just some minor notes.

Nice patch, just some minor notes.
internal/appinfo/xdg_paths.go Outdated
@ -10,10 +10,16 @@ import (
"github.com/adrg/xdg"
)
// This variable can be set at link time to manually specify the home directory for the worker.
Sybren A. Stüvel commented 2023-03-21 16:13:09 +01:00
Owner
Copy Link

Replace This variable can be set with the actual name of the variable, customHome can be set

Also remove the "manually", as this can be done in an automated fashion as well.

Replace `This variable can be set` with the actual name of the variable, `customHome can be set` Also remove the "manually", as this can be done in an automated fashion as well.
ZedDB marked this conversation as resolved
internal/appinfo/xdg_paths.go Outdated
@ -11,2 +11,4 @@
)
// This variable can be set at link time to manually specify the home directory for the worker.
var customHome = ""
Sybren A. Stüvel commented 2023-03-21 16:14:54 +01:00
Owner
Copy Link

Add that this is used in InFlamencoHome() and is still overruled if the FLAMENCO_HOME environment variable is set.

Add that this is used in `InFlamencoHome()` and is still overruled if the `FLAMENCO_HOME` environment variable is set.
ZedDB marked this conversation as resolved
internal/manager/config/config.go Outdated
@ -27,3 +27,2 @@
const (
configFilename = "flamenco-manager.yaml"
var configFilename = "flamenco-manager.yaml"
Sybren A. Stüvel commented 2023-03-21 16:14:07 +01:00
Owner
Copy Link

Document why this is a variable, and that it's not intended to be changed while Flamenco Manager is running.

Document why this is a variable, and that it's not intended to be changed while Flamenco Manager is running.
ZedDB marked this conversation as resolved
internal/worker/config.go Outdated
@ -23,3 +23,3 @@
)
const (
var (
Sybren A. Stüvel commented 2023-03-21 16:14:14 +01:00
Owner
Copy Link

Same comment as above.

Same comment as above.
ZedDB marked this conversation as resolved
Sebastian Parborg force-pushed config from b9f3215743 to d24f96bdff 2023-03-22 12:07:03 +01:00 Compare
Sebastian Parborg commented 2023-03-22 12:07:44 +01:00
Author
Member
Copy Link

Done! :)

Done! :)
Sybren A. Stüvel approved these changes 2023-04-04 12:25:05 +02:00
Sybren A. Stüvel commented 2023-04-04 12:30:01 +02:00
Owner
Copy Link

Manually merged into f6f1ebdd05, but the 'merge conflict checking' is blocking me from marking it as such.

Manually merged into f6f1ebdd053ed208c2d20384d0ec568b170ebf23, but the 'merge conflict checking' is blocking me from marking it as such.
Sebastian Parborg commented 2023-04-04 14:53:57 +02:00
Author
Member
Copy Link

I guess we can close this manually then?

I guess we can close this manually then?
Sybren A. Stüvel commented 2023-04-04 15:41:25 +02:00
Owner
Copy Link

Nah, I just had to edit the project settings and allow marking as 'manually merged'.

Nah, I just had to edit the project settings and allow marking as 'manually merged'.
Sybren A. Stüvel manually merged commit f6f1ebdd05 into main 2023-04-04 15:41:41 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Sybren A. Stüvel
Labels
Clear labels   
Good First Issue
  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Status
Archived

  
Status
Confirmed

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Good First Issue
Priority
High
Priority
Low
Priority
Normal
Status
Archived
Status
Confirmed
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/flamenco#104200
No description provided.
Delete Branch "ZedDB/flamenco:config"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?