OAPI: Removing deprecated Job Statuses #104215

Manually merged
Sybren A. Stüvel merged 2 commits from Adi.Sage/flamenco:remove-construction-failed-as-job-status into main 2023-05-26 11:26:56 +02:00
Contributor

Removing depracated Job Statuses :
archiving, archived, construction-failed
from the flamenco-openapi.yaml file,
as they are no longer being used in Flamenco V3.

(They were possibly being used and carried forward from Flamenco V2)

Removing depracated Job Statuses : `archiving`, `archived`, `construction-failed` from the flamenco-openapi.yaml file, as they are no longer being used in Flamenco V3. (They were possibly being used and carried forward from Flamenco V2)
Adi.Sage added 1 commit 2023-05-23 19:29:00 +02:00
6c8dd9604b Remove 'construction-failed' from Job Status list
in the flamenco-openapi.yaml file
as it is no longer being used in Flamenco V3.

(It was possibly being used in Flamenco V2)
Adi.Sage requested review from Sybren A. Stüvel 2023-05-23 19:29:10 +02:00
Sybren A. Stüvel requested changes 2023-05-24 10:55:06 +02:00
Sybren A. Stüvel left a comment
Owner

Thanks for the PR.

As discussed on Blender Chat, please also remove the job statuses archiving and archived, as they have the same history as construction-failed -- leftovers from Flamenco v2.

Please check https://flamenco.blender.org/development/openapi-commit-guidelines/ as changing the YAML file has a few more steps to take into account. It'll take at least one more commit, to regenerate the code & commit that too.

If it's getting too complex I can do that too, just let me know.

Thanks for the PR. As discussed on Blender Chat, please also remove the job statuses `archiving` and `archived`, as they have the same history as `construction-failed` -- leftovers from Flamenco v2. Please check https://flamenco.blender.org/development/openapi-commit-guidelines/ as changing the YAML file has a few more steps to take into account. It'll take at least one more commit, to regenerate the code & commit that too. If it's getting too complex I can do that too, just let me know.
Adi.Sage added 1 commit 2023-05-25 17:32:04 +02:00
5ba41dff51 Removing 'archiving' and 'archived'
Removing 'archiving' and 'archived'
from the Job Status list
as they are no longer used in Flamenco V3.
Adi.Sage changed title from Remove 'construction-failed' from Job Status list to OAPI: Removing deprecated Job and Task Statuses 2023-05-25 17:33:38 +02:00
Adi.Sage changed title from OAPI: Removing deprecated Job and Task Statuses to OAPI: Removing deprecated Job Statuses 2023-05-25 17:34:11 +02:00
Author
Contributor

@dr.sybren
I have removed the other statuses as you mentioned, and updated the PR title and description to be more inclusive.

Unfortunately I am not able to follow the OpenAPI commit guidelines, and I would appreciate it if someone takes it up further from this point.

@dr.sybren I have removed the other statuses as you mentioned, and updated the PR title and description to be more inclusive. Unfortunately I am not able to follow the [OpenAPI commit guidelines](https://flamenco.blender.org/development/openapi-commit-guidelines/), and I would appreciate it if someone takes it up further from this point.
Sybren A. Stüvel approved these changes 2023-05-26 11:25:15 +02:00
Sybren A. Stüvel left a comment
Owner

Thanks for the PR! I'll handle the rest of the commits.

Thanks for the PR! I'll handle the rest of the commits.
Sybren A. Stüvel manually merged commit b56a610f8d into main 2023-05-26 11:26:56 +02:00
Sign in to join this conversation.
No description provided.