studio/flamenco
studio/flamenco
12
30
Fork 38
Code Issues 63 Pull Requests 5 Releases Wiki Activity

enhance messages when blender is not found #104224

Closed
MichaelC wants to merge 6 commits from michael-2:wrn_blender_not_found_improvement into main
pull from: michael-2:wrn_blender_not_found_improvement
merge into: studio:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 1 Commits 6 Files Changed 1 +12 -9
2 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 0dac4df945 - Show all commits

8
cmd/flamenco-worker/find_exes.go
View File

@ -34,13 +34,15 @@ func findBlender() {
result, err := find_blender.Find(ctx)
switch {
case errors.Is(err, fs.ErrNotExist), errors.Is(err, exec.ErrNotFound):
log.Warn().Msg("Blender could not be found, Flamenco Manager will have to supply a full path")
Sybren A. Stüvel commented 2023-07-03 11:00:24 +02:00
Outdated
Review
Copy Link

I don't think this newline is necessary.

I don't think this newline is necessary.
log.Warn().Msg(`The Worker could not find Blender on this system. Flamenco Manager will have to supply the full path to Blender when Tasks are sent to this Worker. For more help see https://flamenco.blender.org/usage/variables/blender/`)
case err != nil:
log.Warn().AnErr("cause", err).Msg("there was an issue finding Blender on this system, Flamenco Manager will have to supply a full path")
log.Warn().AnErr("cause", err).Msg(`There was an error finding Blender on this system. Flamenco Manager will have to supply the full path to Blender when Tasks are sent to this Worker. For more help see https://flamenco.blender.org/usage/variables/blender/`)
Sybren A. Stüvel commented 2023-07-03 11:01:59 +02:00
Review
Copy Link

The Flamenco Manager will have to supply the full path to Blender when Tasks are sent to this Worker. For more help see https://flamenco.blender.org/usage/variables/blender/ text can be extracted to a constant, so that it doesn't have to be repeated.

Also I don't think the backticks are necessary, regular double quotes should work equally well.

The `Flamenco Manager will have to supply the full path to Blender when Tasks are sent to this Worker. For more help see https://flamenco.blender.org/usage/variables/blender/` text can be extracted to a constant, so that it doesn't have to be repeated. Also I don't think the backticks are necessary, regular double quotes should work equally well.
default:
log.Info().
Str("path", result.FoundLocation).
Str("version", result.BlenderVersion).
Msg("Blender found on this system, it will be used unless Flamenco Manager specifies a path to a different Blender")
Msg("Blender found on this system, it will be used unless the Flamenco Manager configuration specifies a different path.")
}
}

13
web/project-website/content/usage/manager-configuration/_index.md
View File

@ -34,18 +34,19 @@ task_fail_after_softfail_count: 3
variables:
blender:
values:
- platform: linux
value: blender
- platform: windows
value: blender
- platform: darwin
value: blender
- platform: linux
value: /home/sybren/Downloads/blenders/blender-3.2.2-release/blender
- platform: windows
value: B:\Downloads\blenders\blender-3.2.2-release\blender.exe
- platform: darwin
value: /home/sybren/Downloads/blenders/blender-3.2.2-release/blender
blenderArgs:
values:
- platform: all
value: -b -y
```
## Creating a Configuration File
The usual way to create a configuration file is simply by starting Flamenco
Manager. If there is no config file yet, it will start the setup assistant to
create one. If for any reasons the setup assistant is not usable for you, you