studio/flamenco
studio/flamenco
12
30
Fork 38
Code Issues 63 Pull Requests 5 Releases Wiki Activity

faq on worker not finding blender #104225

Closed
MichaelC wants to merge 12 commits from michael-2/flamenco:faq_wrn_blender_not_found into main
pull from: michael-2/flamenco:faq_wrn_blender_not_found
merge into: studio:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 3 Commits 12 Files Changed 1 +26
MichaelC commented 2023-06-27 13:51:09 +02:00
Contributor
Copy Link

Update FAQ with some guidance on how to resolve blender not found warning.

Update FAQ with some guidance on how to resolve blender not found warning.
MichaelC added 1 commit 2023-06-27 13:51:11 +02:00
MichaelC added 1 commit 2023-06-27 14:02:44 +02:00
Sybren A. Stüvel requested changes 2023-07-03 11:08:03 +02:00
Sybren A. Stüvel left a comment
Owner
Copy Link

Thanks, those are nice improvements. I've added a few inline notes to squibble about the details.

Thanks, those are nice improvements. I've added a few inline notes to squibble about the details.
web/project-website/content/faq/_index.md Outdated
@ -64,0 +74,4 @@
There are two ways to resolve this problem:
1. Blender be installed in well known location using Blender installer or
Sybren A. Stüvel commented 2023-07-03 11:05:45 +02:00
Owner
Copy Link

There is no concept of a "well known location" in Flamenco. On Windows it finds Blender via the association of the .blend file extension with an executable. Would you know of a concise way to explain this to people who may not even know what a "file association" is?

The $PATH is correct.

There is no concept of a "well known location" in Flamenco. On Windows it finds Blender via the association of the `.blend` file extension with an executable. Would you know of a concise way to explain this to people who may not even know what a "file association" is? The `$PATH` is correct.
MichaelC commented 2023-07-05 03:30:30 +02:00
Author
Contributor
Copy Link

So I used the phrase "well known location" to head off custom locations or using NFS/NAS mount and what I meant was platform-dependent-paths: https://docs.blender.org/manual/en/latest/advanced/blender_directory_layout.html#platform-dependent-paths.

I did think about describing in more detail how Flamenco searches for Blender but as you point out some end users may not know or should necessarily need to know this level of detail.

So I used the phrase "well known location" to head off custom locations or using NFS/NAS mount and what I meant was platform-dependent-paths: https://docs.blender.org/manual/en/latest/advanced/blender_directory_layout.html#platform-dependent-paths. I did think about describing in more detail how Flamenco searches for Blender but as you point out some end users may not know or should necessarily need to know this level of detail.
web/project-website/content/faq/_index.md Outdated
@ -64,0 +77,4 @@
1. Blender be installed in well known location using Blender installer or
available in the environment $PATH.
2. Use [blender two-way variable configuration][blendervar] for each known `platform` (eg: Windows, Linux or MacOS).
Sybren A. Stüvel commented 2023-07-03 11:07:08 +02:00
Owner
Copy Link

This might be a clearer way to phrase this:

Use a [two-way variable named `blender`][blendervar] for each platform (eg: Windows, Linux or MacOS).
This might be a clearer way to phrase this: ```markdown Use a [two-way variable named `blender`][blendervar] for each platform (eg: Windows, Linux or MacOS). ```
MichaelC commented 2023-07-05 03:30:52 +02:00
Author
Contributor
Copy Link

I included this phrase in my latest update.

I included this phrase in my latest update.
MichaelC added 1 commit 2023-07-05 03:30:30 +02:00
MichaelC added 7 commits 2023-07-05 03:31:23 +02:00
MichaelC added 2 commits 2023-07-05 03:34:59 +02:00
MichaelC commented 2023-07-05 03:36:05 +02:00
Author
Contributor
Copy Link

@dr.sybren - Sorry for all the commits... I managed to mess up a couple of files on my main branch and have reverted them back.
Let me know if you would rather I start the PR over again.

@dr.sybren - Sorry for all the commits... I managed to mess up a couple of files on my main branch and have reverted them back. Let me know if you would rather I start the PR over again.
MichaelC requested review from Sybren A. Stüvel 2023-07-05 03:36:29 +02:00
MichaelC commented 2023-07-05 17:54:09 +02:00
Author
Contributor
Copy Link

Cleaned up commit history in a new PR
#104232

Cleaned up commit history in a new PR https://projects.blender.org/studio/flamenco/pulls/104232
MichaelC closed this pull request 2023-07-05 17:54:10 +02:00
Sybren A. Stüvel commented 2023-07-06 12:40:02 +02:00
Owner
Copy Link

Cleaned up commit history in a new PR
#104232

Please next time just force-push to the same branch. That'll update the PR; there is no needd to create a new one.
If you do decide that a new PR is really the only way to go, update the old PR's description, so that a reader immediately knows that there is a replacement PR (without having to read through all the comments).

> Cleaned up commit history in a new PR > https://projects.blender.org/studio/flamenco/pulls/104232 Please next time just force-push to the same branch. That'll update the PR; there is no needd to create a new one. If you do decide that a new PR is really the only way to go, update the old PR's description, so that a reader immediately knows that there is a replacement PR (without having to read through all the comments).

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Sybren A. Stüvel
Labels
Clear labels   
Good First Issue
  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Status
Archived

  
Status
Confirmed

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Job Type
Custom Flamenco job type

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Good First Issue
Priority
High
Priority
Low
Priority
Normal
Status
Archived
Status
Confirmed
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Job Type
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/flamenco#104225
No description provided.
Delete Branch "michael-2/flamenco:faq_wrn_blender_not_found"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?