studio/flamenco
studio/flamenco
12
30
Fork 38
Code Issues 63 Pull Requests 5 Releases Wiki Activity

Update wording for worker maintenance guidance on Flamenco Manager Console #104227

Closed
MichaelC wants to merge 11 commits from michael-2/flamenco:vue_worker_maintenance_wording into main
pull from: michael-2/flamenco:vue_worker_maintenance_wording
merge into: studio:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 6 Commits 11 Files Changed 1 +14 -5
1 changed files with 14 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit c6877e07d4 - Show all commits

19
web/app/src/components/workers/WorkerDetails.vue
View File

@ -115,11 +115,20 @@
<section class="worker-maintenance">
<h3 class="sub-title">Maintenance</h3>
<p>{{ workerData.name }} is in <span class="worker-status">{{ workerData.status }}</span> state, which means
<template v-if="workerData.status == 'offline'">the Worker can be safely removed.</template>
<template v-else>removing it in this state can cause the Worker to log errors. It
is advised to shut down the Worker before removing it from the
system.</template>
<p>
Sybren A. Stüvel commented 2023-07-03 10:56:28 +02:00
Outdated
Review
Copy Link

I agree with @fsiddi that {name} is awake is nicer than {name} is in awake state. For the error state your improvement is certainly welcome.

I agree with @fsiddi that `{name} is awake` is nicer than `{name} is in awake state`. For the `error` state your improvement is certainly welcome.
{{ workerData.name }} is
Sybren A. Stüvel commented 2023-07-03 10:57:05 +02:00
Outdated
Review
Copy Link

Given that the subject of the sentence is already the worker, I think it's clear enough to replace the worker with it.

Given that the subject of the sentence is already the worker, I think it's clear enough to replace `the worker` with `it`.
<template v-if="workerData.status == 'offline'">
<span class="worker-status">offline</span>, which means it can be safely removed.
</template>
<template v-else>
<template v-if="workerData.status == 'error'">
in <span class="worker-status">error</span>
</template>
<template v-else>
<span class="worker-status">{{ workerData.status }}</span>
</template> state, which means removing it now can cause it to log errors. It
is advised to shut down the Worker before removing it from the system.
</template>
</p>
<p><button @click="deleteWorker">Remove {{ workerData.name }}</button></p>
<p class="hint">