studio/flamenco
studio/flamenco
12
30
Fork 38
Code Issues 63 Pull Requests 5 Releases Wiki Activity

Fix: Tag Interface Delete Button #104256

Manually merged
Sybren A. Stüvel merged 39 commits from Evelinealy/flamenco:tag-interface into main 2023-11-02 16:13:14 +01:00
Conversation 3 Commits 39 Files Changed 1 +28 -24
1 changed files with 28 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 0161e9b028 - Show all commits

52
web/app/src/views/TagsView.vue
View File

@ -121,35 +121,20 @@ export default {
const tag_options = { const tag_options = {
columns: [ columns: [
{ {
title: "", title: 'Name',
headerHozAlign: "right", field: 'name',
formatter: (cell) => { sorter: 'string',
const button = document.createElement("button"); editor: 'input',
button.classList.add("remove-tag-button"); vertAlign: 'center',
button.innerHTML = "X"; widthGrow: 1,
button.addEventListener("click", () => {
const tag = cell.getRow().getData();
this.deleteTag(tag);
});
return button;
},
headerSort: false,
vertAlign: "center",
},
{
title: "Name",
field: "name",
sorter: "string",
editor: "input",
vertAlign: "center",
}, },
{ {
title: 'Description', title: 'Description',
field: 'description', field: 'description',
sorter: 'string', sorter: 'string',
editor: 'input', editor: 'input',
vertAlign: "center", vertAlign: 'center',
widthGrow: 2,
dr.sybren marked this conversation as resolved Outdated
Sybren A. Stüvel commented 2023-09-04 23:34:32 +02:00
Outdated
Review
Copy Link

Add this column to the end, so that it has the same layout as the job blocklist (there the ❌ is on the right as well).

Add this column to the end, so that it has the same layout as the job blocklist (there the ❌ is on the right as well).
formatter(cell) { formatter(cell) {
const cellValue = cell.getData().description; const cellValue = cell.getData().description;
@ -159,8 +144,27 @@ export default {
return cellValue; return cellValue;
}, },
}, },
{
title: '',
headerHozAlign: 'right',
width: 60,
formatter: (cell) => {
const button = document.createElement('button');
button.classList.add('remove-tag-button');
button.innerHTML = '❌';
button.addEventListener('click', () => {
const tag = cell.getRow().getData();
this.deleteTag(tag);
});
return button;
},
headerSort: false,
vertAlign: 'center',
},
], ],
layout: 'fitData', layout: 'fitColumns',
dr.sybren marked this conversation as resolved Outdated
Sybren A. Stüvel commented 2023-09-04 23:35:31 +02:00
Outdated
Review
Copy Link

Not sure if a fixed width is going to work well here, especially when the window gets resized.

Not sure if a fixed width is going to work well here, especially when the window gets resized.
layoutColumnsOnNewData: true, layoutColumnsOnNewData: true,
height: '82%', height: '82%',
selectable: false, selectable: false,