studio/flamenco
studio/flamenco
12
30
Fork 38
Code Issues 63 Pull Requests 5 Releases Wiki Activity

Fix: Tag Interface Delete Button #104256

Manually merged
Sybren A. Stüvel merged 39 commits from Evelinealy/flamenco:tag-interface into main 2023-11-02 16:13:14 +01:00
Conversation 3 Commits 39 Files Changed 1 +4 -10
1 changed files with 4 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit e4527ed7c2 - Show all commits

14
web/app/src/views/TagsView.vue
View File

@ -2,12 +2,6 @@
<div class="col col-tags-list"> <div class="col col-tags-list">
<h2 class="column-title">Available Tags</h2> <h2 class="column-title">Available Tags</h2>
<div class="action-buttons btn-bar-group">
<div class="btn-bar">
<button @click="deleteTag" :disabled="!selectedTag">Delete Tag</button>
</div>
</div>
<div class="action-buttons btn-bar"> <div class="action-buttons btn-bar">
<form @submit="createTag"> <form @submit="createTag">
<div class="create-tag-container"> <div class="create-tag-container">
@ -251,16 +245,16 @@ export default {
}); });
}, },
deleteTag() { deleteTag(tag) {
dr.sybren marked this conversation as resolved Outdated
Sybren A. Stüvel commented 2023-09-04 23:33:12 +02:00
Outdated
Review
Copy Link

This shouldn't happen anyway, so you can just remove the entire conditional return here. Better to raise an error that you can see & debug (because of the tag.id access failing) than to silently ignore mistakes.

This shouldn't happen anyway, so you can just remove the entire conditional return here. Better to raise an error that you can see & debug (because of the `tag.id` access failing) than to silently ignore mistakes.
if (!this.selectedTag) { if (!tag) {
return; return;
} }
const api = new WorkerMgtApi(getAPIClient()); const api = new WorkerMgtApi(getAPIClient());
api api
.deleteWorkerTag(this.selectedTag.id) .deleteWorkerTag(tag.id)
.then(() => { .then(() => {
dr.sybren marked this conversation as resolved Outdated
Sybren A. Stüvel commented 2023-09-04 23:32:39 +02:00
Outdated
Review
Copy Link

This can be removed. The SocketIO handling will already remove the tag, no matter who did the deletion.

This can be removed. The SocketIO handling will already remove the tag, no matter who did the deletion.
this.selectedTag = null; this.tags = this.tags.filter((t) => t.id !== tag.id);
this.tabulator.setData(this.tags); this.tabulator.setData(this.tags);
}) })
.catch((error) => { .catch((error) => {